milvus
milvus copied to clipboard
fix: streamingcoord and streamingnode client support internal tls
https://github.com/milvus-io/milvus/issues/42680
streamingnode/streamingcoord support internal tls
PR: #42685
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xlyslr
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.
The full list of commands accepted by this bot can be found here.
- internal/distributed/streamingnode/OWNERS
- internal/streamingcoord/OWNERS
- internal/streamingnode/OWNERS
- pkg/util/OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xlyslr Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #
@xlyslr
PR of 2.5 branch need set the related master PR.
please add PR: #42685 in your pr description.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #42686
- Title: fix: streamingcoord and streamingnode client support internal tls Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #42686
- Title: fix: streamingcoord and streamingnode client support internal tls Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 70.70%. Comparing base (40ecaa6) to head (0460477).
:warning: Report is 137 commits behind head on 2.5.
:warning: Current head 0460477 differs from pull request most recent head 7e82666
Please upload reports for the commit 7e82666 to get more accurate results.
:x: Your project status has failed because the head coverage (70.70%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
:exclamation: There is a different number of reports uploaded between BASE (40ecaa6) and HEAD (0460477). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (40ecaa6) HEAD (0460477) 3 2
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #42686 +/- ##
===========================================
- Coverage 80.65% 70.70% -9.96%
===========================================
Files 1431 311 -1120
Lines 206231 30005 -176226
===========================================
- Hits 166334 21214 -145120
+ Misses 34043 8791 -25252
+ Partials 5854 0 -5854
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 70.70% <ø> (ø) |
|
| Go | ∅ <ø> (∅) |
|
| see 1120 files with indirect coverage changes |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@xlyslr cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
rerun cpp-unit-test
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #42686
- Title: fix: streamingcoord and streamingnode client support internal tls Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@xlyslr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@xlyslr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@xlyslr cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
rerun cpp-unit-test
/run-cpu-e2e
/assign @chyezh
rerun cpp-unit-test
/lgtm
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
Use /refresh-label to update related check and label manually
/refresh-labe
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
Use /refresh-label to update related check and label manually
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.