milvus
milvus copied to clipboard
enhance: move segcore codes of segment into one package
issue: #33285
- move most cgo opeartions related to search/query into segcore package for reusing for streamingnode.
- add go unittest for segcore operations.
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Attention: Patch coverage is 80.14981% with 106 lines in your changes missing coverage. Please review.
Project coverage is 81.04%. Comparing base (
8188e14) to head (4a23f94). Report is 10 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #37722 +/- ##
===========================================
+ Coverage 68.87% 81.04% +12.17%
===========================================
Files 289 1368 +1079
Lines 25484 190952 +165468
===========================================
+ Hits 17551 154764 +137213
- Misses 7933 30701 +22768
- Partials 0 5487 +5487
| Components | Coverage Δ | |
|---|---|---|
| Client | 72.33% <ø> (∅) |
|
| Core | 68.87% <ø> (ø) |
|
| Go | 83.21% <80.14%> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/querynodev2/segments/cgo_util.go | 28.57% <ø> (ø) |
|
| internal/querynodev2/segments/count_reducer.go | 100.00% <100.00%> (ø) |
|
| internal/querynodev2/segments/reducer.go | 90.90% <ø> (ø) |
|
| internal/querynodev2/segments/retrieve.go | 82.40% <100.00%> (ø) |
|
| internal/querynodev2/segments/search.go | 63.47% <100.00%> (ø) |
|
| internal/querynodev2/segments/segcore.go | 100.00% <100.00%> (ø) |
|
| internal/querynodev2/segments/segment_loader.go | 72.74% <100.00%> (ø) |
|
| internal/querynodev2/server.go | 77.62% <100.00%> (ø) |
|
| internal/querynodev2/tasks/query_stream_task.go | 79.16% <100.00%> (ø) |
|
| internal/querynodev2/tasks/query_task.go | 90.17% <100.00%> (ø) |
|
| ... and 14 more |
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.
rerun go-sdk
@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun cpp-unit-test
@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun cpp-unit-test
rerun cpp-unit-test
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun cpp-unit-test
rerun cpp-unit-test
@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun cpp-unit-test
@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, congqixia
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment