milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: move segcore codes of segment into one package

Open chyezh opened this issue 1 year ago • 4 comments

issue: #33285

  • move most cgo opeartions related to search/query into segcore package for reusing for streamingnode.
  • add go unittest for segcore operations.

chyezh avatar Nov 15 '24 09:11 chyezh

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 15 '24 10:11 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 15 '24 10:11 mergify[bot]

Codecov Report

Attention: Patch coverage is 80.14981% with 106 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (8188e14) to head (4a23f94). Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/segcore/segment.go 79.23% 26 Missing and 12 partials :warning:
internal/querynodev2/segments/segment.go 86.77% 9 Missing and 7 partials :warning:
internal/util/segcore/requests.go 69.23% 8 Missing and 4 partials :warning:
internal/util/segcore/reduce.go 9.09% 5 Missing and 5 partials :warning:
internal/querynodev2/segments/collection.go 62.50% 4 Missing and 2 partials :warning:
internal/util/segcore/collection.go 81.25% 4 Missing and 2 partials :warning:
internal/querynodev2/segments/result.go 16.66% 4 Missing and 1 partial :warning:
internal/querynodev2/segments/segment_l0.go 0.00% 3 Missing :warning:
internal/util/segcore/cgo_util.go 88.46% 2 Missing and 1 partial :warning:
internal/util/segcore/responses.go 75.00% 2 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37722       +/-   ##
===========================================
+ Coverage   68.87%   81.04%   +12.17%     
===========================================
  Files         289     1368     +1079     
  Lines       25484   190952   +165468     
===========================================
+ Hits        17551   154764   +137213     
- Misses       7933    30701    +22768     
- Partials        0     5487     +5487     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.21% <80.14%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/cgo_util.go 28.57% <ø> (ø)
internal/querynodev2/segments/count_reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/reducer.go 90.90% <ø> (ø)
internal/querynodev2/segments/retrieve.go 82.40% <100.00%> (ø)
internal/querynodev2/segments/search.go 63.47% <100.00%> (ø)
internal/querynodev2/segments/segcore.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 72.74% <100.00%> (ø)
internal/querynodev2/server.go 77.62% <100.00%> (ø)
internal/querynodev2/tasks/query_stream_task.go 79.16% <100.00%> (ø)
internal/querynodev2/tasks/query_task.go 90.17% <100.00%> (ø)
... and 14 more

... and 1055 files with indirect coverage changes

codecov[bot] avatar Nov 15 '24 11:11 codecov[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 17 '24 03:11 mergify[bot]

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 22 '24 10:11 mergify[bot]

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 24 '24 07:11 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 24 '24 07:11 mergify[bot]

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 25 '24 03:11 mergify[bot]

rerun go-sdk

chyezh avatar Nov 25 '24 03:11 chyezh

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Nov 25 '24 04:11 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 25 '24 04:11 mergify[bot]

/run-cpu-e2e

chyezh avatar Nov 25 '24 06:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 25 '24 06:11 chyezh

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Nov 25 '24 06:11 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 25 '24 07:11 mergify[bot]

/run-cpu-e2e

chyezh avatar Nov 25 '24 07:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 25 '24 07:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 25 '24 09:11 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 25 '24 09:11 mergify[bot]

/run-cpu-e2e

chyezh avatar Nov 25 '24 11:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 25 '24 11:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 25 '24 11:11 chyezh

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Nov 25 '24 12:11 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 25 '24 13:11 mergify[bot]

/run-cpu-e2e

chyezh avatar Nov 26 '24 01:11 chyezh

rerun cpp-unit-test

chyezh avatar Nov 26 '24 01:11 chyezh

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Nov 26 '24 11:11 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 29 '24 02:11 sre-ci-robot