milvus
milvus copied to clipboard
enhance: try compact small segments first if they may compose a full segment
See #37234
@tedxu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.
@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
rerun go-sdk
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.67%. Comparing base (
2630717) to head (c68558b). Report is 172 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #37709 +/- ##
===========================================
+ Coverage 68.15% 80.67% +12.52%
===========================================
Files 290 1358 +1068
Lines 25392 190699 +165307
===========================================
+ Hits 17306 153849 +136543
- Misses 8086 31418 +23332
- Partials 0 5432 +5432
| Components | Coverage Δ | |
|---|---|---|
| Client | 61.25% <ø> (∅) |
|
| Core | 68.93% <ø> (+0.77%) |
:arrow_up: |
| Go | 83.19% <100.00%> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/compaction_trigger.go | 84.77% <100.00%> (ø) |
|
| internal/datacoord/knapsack.go | 100.00% <100.00%> (ø) |
@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.
/run-cpu-e2e
@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, tedxu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datacoord/OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment