milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: add tasks page into management WebUI

Open jaime0815 opened this issue 1 year ago • 3 comments

issue: https://github.com/milvus-io/milvus/issues/36784

Add runtime metrics for the tasks:

  • build index task
  • compaction task
  • import task
  • balance (including load/release of segments/channels and some leader tasks on querycoord)
  • sync task

jaime0815 avatar Oct 18 '24 13:10 jaime0815

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 18 '24 14:10 mergify[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 19 '24 15:10 mergify[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 22 '24 13:10 mergify[bot]

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 22 '24 13:10 mergify[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 04:10 mergify[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 04:10 mergify[bot]

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Oct 23 '24 15:10 mergify[bot]

@jaime0815 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Oct 24 '24 13:10 mergify[bot]

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 25 '24 04:10 mergify[bot]

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 25 '24 04:10 mergify[bot]

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Oct 25 '24 04:10 mergify[bot]

rerun cpp-unit-test

jaime0815 avatar Oct 25 '24 04:10 jaime0815

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 25 '24 07:10 mergify[bot]

/run-cpu-e2e

jaime0815 avatar Oct 25 '24 07:10 jaime0815

/lgtm

SimFG avatar Oct 25 '24 08:10 SimFG

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] avatar Oct 25 '24 09:10 mergify[bot]

Codecov Report

Attention: Patch coverage is 85.79336% with 77 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (8630447) to head (036f606). Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/server.go 50.00% 8 Missing and 4 partials :warning:
internal/proxy/http_req_impl.go 70.96% 8 Missing and 1 partial :warning:
internal/querycoordv2/task/task.go 84.00% 8 Missing :warning:
internal/datacoord/metrics_info.go 87.03% 5 Missing and 2 partials :warning:
internal/flushcommon/syncmgr/sync_manager.go 46.15% 5 Missing and 2 partials :warning:
internal/querycoordv2/task/scheduler.go 56.25% 5 Missing and 2 partials :warning:
internal/datacoord/index_meta.go 93.33% 3 Missing and 1 partial :warning:
internal/proxy/impl.go 55.55% 2 Missing and 2 partials :warning:
internal/datacoord/compaction_task_meta.go 89.28% 2 Missing and 1 partial :warning:
internal/datacoord/import_meta.go 93.87% 2 Missing and 1 partial :warning:
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37002       +/-   ##
===========================================
+ Coverage   66.87%   80.84%   +13.96%     
===========================================
  Files         276     1317     +1041     
  Lines       24994   183017   +158023     
===========================================
+ Hits        16715   147956   +131241     
- Misses       8279    29901    +21622     
- Partials        0     5160     +5160     
Files with missing lines Coverage Δ
internal/datacoord/import_util.go 87.13% <100.00%> (ø)
internal/datacoord/services.go 85.99% <100.00%> (ø)
internal/datanode/importv2/util.go 65.11% <100.00%> (ø)
internal/datanode/metrics_info.go 100.00% <100.00%> (ø)
internal/datanode/services.go 85.01% <100.00%> (ø)
internal/distributed/proxy/service.go 85.15% <ø> (ø)
internal/flushcommon/syncmgr/meta_writer.go 79.16% <100.00%> (ø)
internal/flushcommon/syncmgr/options.go 100.00% <100.00%> (ø)
internal/flushcommon/syncmgr/serializer.go 100.00% <100.00%> (ø)
internal/flushcommon/syncmgr/storage_serializer.go 63.42% <100.00%> (ø)
... and 27 more

... and 1024 files with indirect coverage changes

codecov[bot] avatar Oct 25 '24 11:10 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 28 '24 02:10 sre-ci-robot

/lgtm

SimFG avatar Oct 28 '24 02:10 SimFG