milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: add an unify vector index config checker

Open foxspy opened this issue 1 year ago • 22 comments

issue: #34298

foxspy avatar Oct 14 '24 08:10 foxspy

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Oct 14 '24 08:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 14 '24 09:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 15 '24 05:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 15 '24 06:10 mergify[bot]

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 15 '24 10:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 15 '24 10:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 16 '24 04:10 mergify[bot]

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 16 '24 04:10 mergify[bot]

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 16 '24 05:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 16 '24 05:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 17 '24 03:10 mergify[bot]

/run-cpu-e2e

foxspy avatar Oct 17 '24 03:10 foxspy

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 17 '24 15:10 mergify[bot]

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 17 '24 15:10 mergify[bot]

/run-cpu-e2e

foxspy avatar Oct 17 '24 15:10 foxspy

rerun go-sdk

foxspy avatar Oct 17 '24 15:10 foxspy

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 17 '24 15:10 mergify[bot]

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Oct 17 '24 15:10 mergify[bot]

Codecov Report

Attention: Patch coverage is 54.66102% with 107 lines in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (1d61b60) to head (49d96c4). Report is 37 commits behind head on master.

:exclamation: Current head 49d96c4 differs from pull request most recent head bceca38

Please upload reports for the commit bceca38 to get more accurate results.

Files with missing lines Patch % Lines
internal/core/src/segcore/vector_index_c.cpp 0.00% 40 Missing :warning:
internal/util/indexparamcheck/utils.go 43.75% 8 Missing and 1 partial :warning:
...ernal/util/indexparamcheck/vector_index_checker.go 86.15% 6 Missing and 3 partials :warning:
internal/util/indexparamcheck/bin_flat_checker.go 0.00% 6 Missing :warning:
internal/util/indexparamcheck/hnsw_checker.go 0.00% 6 Missing :warning:
...ernal/util/indexparamcheck/bin_ivf_flat_checker.go 0.00% 4 Missing :warning:
...util/indexparamcheck/binary_vector_base_checker.go 0.00% 4 Missing :warning:
...ndexparamcheck/sparse_float_vector_base_checker.go 0.00% 4 Missing :warning:
internal/util/indexparamcheck/cagra_checker.go 0.00% 3 Missing :warning:
...nternal/util/indexparamcheck/auto_index_checker.go 0.00% 2 Missing :warning:
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #36844       +/-   ##
===========================================
+ Coverage   66.87%   72.19%    +5.31%     
===========================================
  Files         276     1311     +1035     
  Lines       24994   183678   +158684     
===========================================
+ Hits        16715   132600   +115885     
- Misses       8279    45959    +37680     
- Partials        0     5119     +5119     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 96.08% <ø> (ø)
internal/datacoord/index_service.go 92.93% <ø> (ø)
internal/proxy/task_index.go 77.47% <100.00%> (ø)
internal/proxy/util.go 90.02% <ø> (ø)
internal/querynodev2/segments/index_attr_cache.go 95.45% <ø> (ø)
internal/querynodev2/segments/segment.go 65.32% <ø> (ø)
internal/querynodev2/segments/utils.go 53.29% <ø> (ø)
internal/util/indexparamcheck/conf_adapter_mgr.go 100.00% <100.00%> (ø)
...ernal/util/indexparamcheck/hybrid_index_checker.go 100.00% <100.00%> (ø)
internal/util/indexparamcheck/inverted_checker.go 100.00% <100.00%> (ø)
... and 30 more

... and 1252 files with indirect coverage changes

codecov[bot] avatar Oct 17 '24 17:10 codecov[bot]

/run-cpu-e2e

foxspy avatar Oct 18 '24 02:10 foxspy

rerun go-sdk

foxspy avatar Oct 18 '24 02:10 foxspy

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 07:10 mergify[bot]

/run-cpu-e2e

foxspy avatar Oct 23 '24 07:10 foxspy

/run-cpu-e2e

foxspy avatar Oct 23 '24 08:10 foxspy

/run-cpu-e2e

foxspy avatar Oct 23 '24 11:10 foxspy

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 11:10 mergify[bot]

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 13:10 mergify[bot]

/run-cpu-e2e

foxspy avatar Oct 23 '24 16:10 foxspy

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 23 '24 16:10 mergify[bot]

@foxspy [pytest : test] [2024-10-23 16:48:58 - ERROR - pymilvus.decorators]: RPC error: [create_index], <MilvusException: (code=1100, message=metric type not found or not supported, supported: [IP]: invalid parameter[expected=valid index params][actual=invalid index params])>, <Time:{'RPC start': '2024-10-23 16:48:58.544908', 'RPC error': '2024-10-23 16:48:58.547414'}> (decorators.py:140)

liliu-z avatar Oct 24 '24 14:10 liliu-z