milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: [cherry-pick] clean failed/timeout compaction task in compactionHandler

Open wayblink opened this issue 1 year ago • 5 comments

issue: #35711 master pr: #34991

wayblink avatar Aug 28 '24 06:08 wayblink

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Aug 28 '24 06:08 mergify[bot]

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (16daf91) to head (603c4aa). Report is 183 commits behind head on 2.4.

:exclamation: Current head 603c4aa differs from pull request most recent head 7d26b0f

Please upload reports for the commit 7d26b0f to get more accurate results.

Files with missing lines Patch % Lines
internal/datacoord/partition_stats_meta.go 78.94% 2 Missing and 2 partials :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35759      +/-   ##
==========================================
+ Coverage   71.90%   81.17%   +9.26%     
==========================================
  Files        1060     1056       -4     
  Lines      139553   139281     -272     
==========================================
+ Hits       100349   113057   +12708     
+ Misses      34918    21931   -12987     
- Partials     4286     4293       +7     
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 79.14% <100.00%> (-1.89%) :arrow_down:
internal/datacoord/compaction_task.go 88.88% <ø> (ø)
internal/datacoord/compaction_task_clustering.go 82.15% <100.00%> (+3.00%) :arrow_up:
internal/datacoord/compaction_task_l0.go 100.00% <100.00%> (+2.31%) :arrow_up:
internal/datacoord/compaction_task_mix.go 68.12% <100.00%> (+5.21%) :arrow_up:
pkg/util/merr/errors.go 88.23% <ø> (ø)
pkg/util/merr/utils.go 84.68% <100.00%> (+0.10%) :arrow_up:
internal/datacoord/partition_stats_meta.go 52.94% <78.94%> (+9.35%) :arrow_up:

... and 300 files with indirect coverage changes

codecov[bot] avatar Aug 28 '24 07:08 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 13 '24 09:09 sre-ci-robot

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 13 '24 09:09 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Oct 17 '24 02:10 stale[bot]