milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Add meta pkg for datacoord

Open congqixia opened this issue 1 year ago • 7 comments

See also #28861

Add meta package to replace old one in next PRs.

congqixia avatar Aug 27 '24 07:08 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Aug 27 '24 07:08 sre-ci-robot

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Aug 27 '24 08:08 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Aug 27 '24 10:08 mergify[bot]

/run-cpu-e2e

congqixia avatar Aug 27 '24 10:08 congqixia

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Aug 27 '24 11:08 mergify[bot]

Codecov Report

Attention: Patch coverage is 38.40937% with 999 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (3123093) to head (77b8da9). Report is 367 commits behind head on master.

:exclamation: Current head 77b8da9 differs from pull request most recent head 8b8a0a6

Please upload reports for the commit 8b8a0a6 to get more accurate results.

Files with missing lines Patch % Lines
internal/datacoord/meta/segment/manager.go 0.00% 238 Missing :warning:
internal/datacoord/meta/segment/batch_operator.go 0.00% 198 Missing :warning:
internal/datacoord/meta/index/index_meta.go 73.40% 151 Missing and 3 partials :warning:
...acoord/meta/partitionstats/partition_stats_meta.go 32.47% 75 Missing and 4 partials :warning:
internal/datacoord/meta/segment/operator.go 9.87% 73 Missing :warning:
internal/datacoord/meta/segment/segment_info.go 30.00% 63 Missing :warning:
internal/datacoord/meta/segment/filter.go 0.00% 51 Missing :warning:
internal/datacoord/meta/segment/types.go 0.00% 46 Missing :warning:
.../datacoord/meta/compaction/compaction_task_meta.go 47.36% 36 Missing and 4 partials :warning:
internal/datacoord/meta/segment/util.go 0.00% 22 Missing :warning:
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35734      +/-   ##
==========================================
- Coverage   81.59%   71.91%   -9.69%     
==========================================
  Files        1267     1251      -16     
  Lines      150973   149683    -1290     
==========================================
- Hits       123190   107643   -15547     
- Misses      22891    37256   +14365     
+ Partials     4892     4784     -108     
Files with missing lines Coverage Δ
internal/datacoord/meta/analyze/analyze_meta.go 100.00% <100.00%> (ø)
internal/datacoord/meta/segment/condition.go 0.00% <0.00%> (ø)
internal/datacoord/meta/segment/allocation.go 0.00% <0.00%> (ø)
internal/datacoord/meta/segment/util.go 0.00% <0.00%> (ø)
.../datacoord/meta/compaction/compaction_task_meta.go 47.36% <47.36%> (ø)
internal/datacoord/meta/segment/types.go 0.00% <0.00%> (ø)
internal/datacoord/meta/segment/filter.go 0.00% <0.00%> (ø)
internal/datacoord/meta/segment/segment_info.go 30.00% <30.00%> (ø)
internal/datacoord/meta/segment/operator.go 9.87% <9.87%> (ø)
...acoord/meta/partitionstats/partition_stats_meta.go 32.47% <32.47%> (ø)
... and 3 more

... and 462 files with indirect coverage changes

codecov[bot] avatar Aug 27 '24 12:08 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Oct 17 '24 02:10 stale[bot]