milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: fix empty indices of sparse float

Open sunby opened this issue 1 year ago • 4 comments

https://github.com/milvus-io/milvus/issues/35401

sunby avatar Aug 09 '24 13:08 sunby

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Aug 09 '24 13:08 mergify[bot]

/approve /lgtm

czs007 avatar Aug 12 '24 07:08 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Aug 12 '24 07:08 sre-ci-robot

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Sep 10 '24 03:09 mergify[bot]

rerun go-sdk

sunby avatar Sep 10 '24 04:09 sunby

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (5aedc16) to head (6fd5c11). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/mmap/Utils.h 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35403      +/-   ##
==========================================
- Coverage   81.60%   72.63%   -8.98%     
==========================================
  Files        1268     1268              
  Lines      151077   151078       +1     
==========================================
- Hits       123283   109728   -13555     
- Misses      22895    36452   +13557     
+ Partials     4899     4898       -1     
Files with missing lines Coverage Δ
internal/core/src/mmap/Utils.h 0.00% <0.00%> (-71.24%) :arrow_down:

... and 236 files with indirect coverage changes

codecov[bot] avatar Sep 10 '24 05:09 codecov[bot]

/lgtm

czs007 avatar Sep 10 '24 06:09 czs007