milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: timetick interceptor implementation

Open chyezh opened this issue 1 year ago • 6 comments

issue: #33285

  • optimize the message package
  • add interceptor package to achieve append operation intercepting.
  • add timetick interceptor to attach timetick properties for message.
  • add timetick background task to send timetick message.

chyezh avatar Jun 27 '24 08:06 chyezh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 27 '24 08:06 sre-ci-robot

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 27 '24 11:06 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 28 '24 01:06 mergify[bot]

/run-cpu-e2e

chyezh avatar Jun 28 '24 02:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 28 '24 02:06 mergify[bot]

Codecov Report

Attention: Patch coverage is 91.04478% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (d2bc4a5) to head (915c301). Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34238      +/-   ##
==========================================
- Coverage   84.61%   80.87%   -3.74%     
==========================================
  Files         817     1096     +279     
  Lines      113473   137783   +24310     
==========================================
+ Hits        96013   111438   +15425     
- Misses      13238    22116    +8878     
- Partials     4222     4229       +7     
Files Coverage Δ
internal/streamingnode/server/resource/resource.go 100.00% <100.00%> (ø)
...rnal/streamingnode/server/resource/test_utility.go 100.00% <100.00%> (ø)
...e/server/resource/timestamp/timestamp_allocator.go 100.00% <100.00%> (ø)
...gnode/server/wal/interceptors/chain_interceptor.go 100.00% <100.00%> (ø)
...ode/server/wal/interceptors/timetick/ack/detail.go 100.00% <100.00%> (ø)
pkg/streaming/util/message/properties.go 100.00% <ø> (ø)
pkg/streaming/walimpls/impls/pulsar/scanner.go 84.84% <100.00%> (ø)
...g/streaming/walimpls/impls/walimplstest/builder.go 100.00% <100.00%> (ø)
pkg/streaming/walimpls/test_framework.go 95.34% <100.00%> (-0.21%) :arrow_down:
pkg/util/syncutil/future.go 100.00% <100.00%> (ø)
... and 11 more

... and 307 files with indirect coverage changes

codecov[bot] avatar Jun 28 '24 03:06 codecov[bot]

/lgtm

jaime0815 avatar Jul 02 '24 06:07 jaime0815