milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: implement streaming node server service

Open chyezh opened this issue 1 year ago • 3 comments

issue: #33285

  • implement producing and consuming server of message
  • implement management operation for streaming node server

chyezh avatar Jun 25 '24 12:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 25 '24 12:06 mergify[bot]

Codecov Report

Attention: Patch coverage is 85.53191% with 68 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (ba04981) to head (e611725). Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34166      +/-   ##
==========================================
+ Coverage   79.70%   79.81%   +0.10%     
==========================================
  Files        1119     1127       +8     
  Lines      138783   139380     +597     
==========================================
+ Hits       110614   111241     +627     
+ Misses      23926    23864      -62     
- Partials     4243     4275      +32     
Files Coverage Δ
internal/proxy/search_util.go 84.61% <ø> (ø)
...ice/handler/consumer/consume_grpc_server_helper.go 100.00% <100.00%> (ø)
...ice/handler/producer/produce_grpc_server_helper.go 100.00% <100.00%> (ø)
...al/streamingnode/server/walmanager/manager_impl.go 87.14% <100.00%> (ø)
...al/streamingnode/server/walmanager/wal_lifetime.go 89.55% <100.00%> (ø)
...reamingutil/service/contextutil/create_consumer.go 100.00% <100.00%> (ø)
...reamingutil/service/contextutil/create_producer.go 100.00% <100.00%> (ø)
internal/util/streamingutil/status/rpc_error.go 83.33% <ø> (ø)
...ernal/util/streamingutil/status/streaming_error.go 95.83% <100.00%> (+0.18%) :arrow_up:
.../util/streamingutil/typeconverter/pchannel_info.go 100.00% <100.00%> (ø)
... and 13 more

... and 66 files with indirect coverage changes

codecov[bot] avatar Jun 27 '24 13:06 codecov[bot]

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Jul 05 '24 10:07 mergify[bot]

rerun ut

chyezh avatar Jul 05 '24 13:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 05 '24 15:07 mergify[bot]

rerun ut

chyezh avatar Jul 06 '24 09:07 chyezh

/lgtm

jaime0815 avatar Jul 08 '24 12:07 jaime0815

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 08 '24 23:07 sre-ci-robot