milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: wal adaptor implementation

Open chyezh opened this issue 1 year ago • 2 comments

issue: #33285

  • add adaptor to implement walimpls into wal interface.
  • add interceptor package to achieve append operation intercepting.
  • add timetick interceptor to attach timetick properties for message.
  • add timetick background task to send timetick message.
  • add test for wal.

chyezh avatar Jun 25 '24 02:06 chyezh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh To complete the pull request process, please assign wxyucs after the PR has been reviewed. You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 25 '24 02:06 sre-ci-robot

Codecov Report

Attention: Patch coverage is 90.07444% with 40 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (feb13cd) to head (beeeff8). Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34122      +/-   ##
==========================================
+ Coverage   80.58%   80.85%   +0.27%     
==========================================
  Files        1095     1114      +19     
  Lines      137929   138464     +535     
==========================================
+ Hits       111145   111958     +813     
+ Misses      22573    22254     -319     
- Partials     4211     4252      +41     
Files Coverage Δ
...ternal/streamingnode/server/wal/adaptor/builder.go 66.66% <100.00%> (ø)
...nternal/streamingnode/server/wal/adaptor/opener.go 100.00% <100.00%> (ø)
...node/server/wal/utility/immutable_message_queue.go 100.00% <100.00%> (ø)
...l/streamingnode/server/wal/utility/message_heap.go 100.00% <100.00%> (ø)
...streamingnode/server/wal/utility/reorder_buffer.go 100.00% <100.00%> (ø)
internal/util/streamingutil/status/checker.go 100.00% <100.00%> (ø)
...util/streamingutil/status/client_stream_wrapper.go 100.00% <100.00%> (ø)
internal/util/streamingutil/util/id_allocator.go 100.00% <100.00%> (ø)
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/util/typeutil/type.go 0.00% <ø> (ø)
... and 7 more

... and 42 files with indirect coverage changes

codecov[bot] avatar Jun 27 '24 11:06 codecov[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 07:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 02 '24 07:07 chyezh

rerun ut

chyezh avatar Jul 02 '24 09:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 11:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 02 '24 11:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 12:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 02 '24 12:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 13:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 02 '24 13:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 15:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 03 '24 00:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 03 '24 03:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 03 '24 04:07 chyezh

/run-cpu-e2e

chyezh avatar Jul 03 '24 05:07 chyezh

/run-cpu-e2e

chyezh avatar Jul 03 '24 06:07 chyezh

/run-cpu-e2e

chyezh avatar Jul 03 '24 07:07 chyezh

/run-cpu-e2e

chyezh avatar Jul 03 '24 09:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 03 '24 15:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 04 '24 00:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 04 '24 00:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 04 '24 00:07 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 04 '24 00:07 mergify[bot]

/run-cpu-e2e

chyezh avatar Jul 04 '24 01:07 chyezh

All refinements or fixes will be done in the next PR.

jaime0815 avatar Jul 04 '24 07:07 jaime0815

/lgtm

jaime0815 avatar Jul 04 '24 07:07 jaime0815