milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: [2.4] add config to control whether to init public role permissions

Open SimFG opened this issue 1 year ago • 3 comments

issue: #33164 pr: #33165

SimFG avatar May 20 '24 07:05 SimFG

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (cf77659) to head (5afd2b0). Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33174      +/-   ##
==========================================
+ Coverage   82.11%   82.12%   +0.01%     
==========================================
  Files        1005     1005              
  Lines      128043   128049       +6     
==========================================
+ Hits       105140   105166      +26     
+ Misses      18922    18908      -14     
+ Partials     3981     3975       -6     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (+<0.01%) :arrow_up:
internal/rootcoord/root_coord.go 91.96% <77.77%> (+0.02%) :arrow_up:

... and 21 files with indirect coverage changes

codecov[bot] avatar May 20 '24 10:05 codecov[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 20 '24 13:05 mergify[bot]

/lgtm /approve

xiaofan-luan avatar May 21 '24 14:05 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 21 '24 14:05 sre-ci-robot