milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: async cgo utility

Open chyezh opened this issue 1 year ago • 10 comments

issue: #30926, #33132

  • implement future-based cgo utility.

chyezh avatar May 17 '24 08:05 chyezh

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 17 '24 08:05 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 17 '24 09:05 mergify[bot]

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 19 '24 04:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 82.02247% with 64 lines in your changes missing coverage. Please review.

Project coverage is 81.38%. Comparing base (60baaed) to head (036a8ec). Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33133      +/-   ##
==========================================
+ Coverage   81.23%   81.38%   +0.15%     
==========================================
  Files        1029     1038       +9     
  Lines      132215   133169     +954     
==========================================
+ Hits       107399   108377     +978     
+ Misses      20766    20725      -41     
- Partials     4050     4067      +17     
Files Coverage Δ
internal/core/src/common/EasyAssert.h 83.33% <100.00%> (-0.88%) :arrow_down:
internal/util/cgo/errors.go 100.00% <100.00%> (ø)
internal/util/cgo/futures_test_case.go 100.00% <100.00%> (ø)
internal/util/cgo/options.go 100.00% <100.00%> (ø)
internal/util/cgo/pool.go 100.00% <100.00%> (ø)
internal/util/cgo/state.go 100.00% <100.00%> (ø)
pkg/util/merr/errors.go 86.95% <ø> (ø)
internal/core/src/futures/Ready.h 96.29% <96.29%> (ø)
internal/util/cgo/futures.go 98.48% <98.48%> (ø)
internal/util/cgo/manager_active.go 94.44% <94.44%> (ø)
... and 6 more

... and 234 files with indirect coverage changes

codecov[bot] avatar May 20 '24 03:05 codecov[bot]

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 20 '24 07:05 mergify[bot]

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar May 20 '24 09:05 mergify[bot]

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 20 '24 13:05 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 20 '24 13:05 mergify[bot]

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 20 '24 14:05 mergify[bot]

/lgtm

longjiquan avatar May 21 '24 10:05 longjiquan

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 27 '24 04:05 mergify[bot]

rerun ut

chyezh avatar May 27 '24 10:05 chyezh

rerun ut

chyezh avatar May 27 '24 11:05 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 07 '24 03:06 mergify[bot]

/lgtm /approve

xiaofan-luan avatar Jun 09 '24 14:06 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 09 '24 14:06 sre-ci-robot