milvus
milvus copied to clipboard
enhance: Store SparseFloatVector into parquet as JSON string
Issue: #22837
@cydrain E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@cydrain ut workflow job failed, comment rerun ut
can trigger the job again.
/lgtm
Codecov Report
Attention: Patch coverage is 74.73684%
with 48 lines
in your changes are missing coverage. Please review.
Project coverage is 82.12%. Comparing base (
1671c78
) to head (20f04a9
). Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #33101 +/- ##
==========================================
- Coverage 82.18% 82.12% -0.07%
==========================================
Files 1006 1006
Lines 128428 128463 +35
==========================================
- Hits 105554 105500 -54
- Misses 18902 18962 +60
- Partials 3972 4001 +29
Files | Coverage Δ | |
---|---|---|
internal/util/importutilv2/json/row_parser.go | 64.02% <100.00%> (ø) |
|
internal/util/importutilv2/parquet/util.go | 73.71% <100.00%> (+0.30%) |
:arrow_up: |
pkg/util/typeutil/convension.go | 100.00% <100.00%> (ø) |
|
internal/util/testutil/test_util.go | 93.95% <81.81%> (-0.57%) |
:arrow_down: |
pkg/util/typeutil/schema.go | 86.03% <77.77%> (-0.09%) |
:arrow_down: |
internal/util/importutilv2/parquet/field_reader.go | 72.97% <72.15%> (-1.25%) |
:arrow_down: |
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, cydrain
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment