milvus
milvus copied to clipboard
fix: remove date in the end of ubuntu base image version
CVE issues https://github.com/milvus-io/milvus/issues/31997 This PR will fix 32 LOW and 42 MEDIUM CVEs
ubuntu:focal-20220426 (ubuntu 20.04)
Total: 99 (UNKNOWN: 0, LOW: 55, MEDIUM: 44, HIGH: 0, CRITICAL: 0)
ubuntu:focal (ubuntu 20.04)
Total: 25 (UNKNOWN: 0, LOW: 23, MEDIUM: 2, HIGH: 0, CRITICAL: 0)
Welcome @weiZhenkun! It looks like this is your first PR to milvus-io/milvus 🎉
@weiZhenkun
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
-
feat:
for introducing a new feature. -
fix:
for bug fixes. -
enhance:
for improvements to existing functionality. -
test
: for add tests to existing functionality. -
doc
: for modifying documentation. -
auto
: for the pull request from bot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type
is one of feat
, fix
, enhance
, test
or doc
.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
/run-cpu-e2e
@weiZhenkun E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@LoveEachDay could you review this PR?
@xiaofan-luan could you review this PR?
@weiZhenkun It's recommended to use a specific tag instead only focal
, like focal-2024010
.
https://github.com/zilliztech/attu/blob/main/Dockerfile#L22 https://github.com/milvus-io/bitnami-docker-etcd/blob/3.5.0-new/3.5/debian-11/Dockerfile#L1 what about here?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.20%. Comparing base (
dd9919a
) to head (9df6d8e
). Report is 157 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #33073 +/- ##
==========================================
+ Coverage 82.14% 82.20% +0.05%
==========================================
Files 1006 1009 +3
Lines 128194 128856 +662
==========================================
+ Hits 105306 105924 +618
- Misses 18919 18944 +25
- Partials 3969 3988 +19
https://github.com/zilliztech/attu/blob/main/Dockerfile#L22 https://github.com/milvus-io/bitnami-docker-etcd/blob/3.5.0-new/3.5/debian-11/Dockerfile#L1 what about here?
We don't release attu and etcd image frequently, while milvus image are building after every pr has been merged. So keep the runtime base image stable is critical.
/run-cpu-e2e
@LoveEachDay Change to latest version focal-20240427 now, please review, thanks.
/assign @yanliang567
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, LoveEachDay, weiZhenkun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~build/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment