milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: use Delete instead of DeletePartialMatch to remove metrics

Open jaime0815 opened this issue 1 year ago • 3 comments

jaime0815 avatar May 13 '24 14:05 jaime0815

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 15:05 mergify[bot]

/run-cpu-e2e

jaime0815 avatar May 13 '24 15:05 jaime0815

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 82.06%. Comparing base (efdbd8e) to head (233bfd6). Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33029      +/-   ##
==========================================
- Coverage   82.12%   82.06%   -0.06%     
==========================================
  Files        1007     1005       -2     
  Lines      127726   127660      -66     
==========================================
- Hits       104894   104765     -129     
- Misses      18875    18920      +45     
- Partials     3957     3975      +18     
Files Coverage Δ
internal/datacoord/services.go 85.71% <ø> (-0.05%) :arrow_down:
internal/metastore/kv/datacoord/kv_catalog.go 81.61% <ø> (-0.04%) :arrow_down:
pkg/metrics/datacoord_metrics.go 76.92% <45.45%> (-23.08%) :arrow_down:
internal/datacoord/meta.go 92.62% <35.71%> (-0.87%) :arrow_down:

... and 44 files with indirect coverage changes

codecov[bot] avatar May 13 '24 17:05 codecov[bot]

/approve /lgtm

czs007 avatar May 14 '24 06:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 14 '24 06:05 sre-ci-robot