milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Add memory size for insert binlog

Open xiaocai2333 opened this issue 9 months ago • 3 comments

issue: #33005

  1. add MemorySize field for insert binlog.
  2. LogSize means the file size in the storage object.
  3. MemorySize means the size of the data in the memory.

xiaocai2333 avatar May 13 '24 12:05 xiaocai2333

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar May 13 '24 12:05 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 13 '24 12:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (1d48d0a) to head (a44b154). Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33025      +/-   ##
==========================================
- Coverage   82.14%   82.08%   -0.06%     
==========================================
  Files        1005     1005              
  Lines      128103   128155      +52     
==========================================
- Hits       105224   105201      -23     
- Misses      18911    18964      +53     
- Partials     3968     3990      +22     
Files Coverage Δ
internal/datacoord/compaction_trigger.go 83.77% <100.00%> (ø)
internal/datacoord/compaction_view.go 88.31% <100.00%> (+11.03%) :arrow_up:
internal/datacoord/segment_info.go 87.30% <100.00%> (ø)
internal/datacoord/util.go 99.13% <100.00%> (ø)
internal/datanode/binlog_io.go 91.86% <100.00%> (+0.06%) :arrow_up:
internal/datanode/syncmgr/task.go 100.00% <100.00%> (ø)
internal/metastore/kv/datacoord/kv_catalog.go 81.72% <100.00%> (+0.07%) :arrow_up:
internal/querynodev2/segments/index_attr_cache.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 73.62% <100.00%> (+0.12%) :arrow_up:
internal/querynodev2/services.go 91.04% <100.00%> (-0.34%) :arrow_down:
... and 5 more

... and 32 files with indirect coverage changes

codecov[bot] avatar May 13 '24 15:05 codecov[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 14 '24 03:05 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 14 '24 03:05 mergify[bot]

/lgtm

chyezh avatar May 14 '24 04:05 chyezh

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 09:05 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 10:05 mergify[bot]

/run-cpu-e2e

xiaocai2333 avatar May 14 '24 11:05 xiaocai2333

/lgtm /approve

xiaofan-luan avatar May 14 '24 13:05 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 14 '24 13:05 sre-ci-robot

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 15:05 mergify[bot]

/run-cpu-e2e

xiaocai2333 avatar May 14 '24 15:05 xiaocai2333

/lgtm

czs007 avatar May 15 '24 04:05 czs007