milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: update knowhere version

Open chasingegg opened this issue 9 months ago • 6 comments

chasingegg avatar May 13 '24 07:05 chasingegg

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 13 '24 07:05 sre-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.09%. Comparing base (293f14a) to head (5057762). Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33011      +/-   ##
==========================================
+ Coverage   82.06%   82.09%   +0.03%     
==========================================
  Files        1007     1007              
  Lines      127699   127699              
==========================================
+ Hits       104793   104835      +42     
+ Misses      18931    18907      -24     
+ Partials     3975     3957      -18     

see 37 files with indirect coverage changes

codecov[bot] avatar May 13 '24 10:05 codecov[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 10:05 mergify[bot]

/run-cpu-e2e

chasingegg avatar May 13 '24 11:05 chasingegg

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 11:05 mergify[bot]

/run-cpu-e2e

chasingegg avatar May 13 '24 11:05 chasingegg

could we explain what's in this commit?

xiaofan-luan avatar May 14 '24 02:05 xiaofan-luan

There are some cardinal commit need to be picked, but master already updated to a newer version of knowhere, so this PR is not needed actually.

chasingegg avatar May 14 '24 02:05 chasingegg