milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: should init access logger before init server

Open aoiasd opened this issue 1 year ago • 7 comments

relate: https://github.com/milvus-io/milvus/issues/32968

aoiasd avatar May 11 '24 06:05 aoiasd

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 06:05 mergify[bot]

/run-cpu-e2e

jaime0815 avatar May 11 '24 07:05 jaime0815

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.09%. Comparing base (293f14a) to head (1a07242). Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32976      +/-   ##
==========================================
+ Coverage   82.06%   82.09%   +0.03%     
==========================================
  Files        1007     1007              
  Lines      127699   127699              
==========================================
+ Hits       104793   104835      +42     
+ Misses      18931    18900      -31     
+ Partials     3975     3964      -11     
Files Coverage Δ
internal/distributed/proxy/service.go 84.08% <100.00%> (+0.02%) :arrow_up:
internal/proxy/proxy.go 70.34% <ø> (-2.01%) :arrow_down:

... and 33 files with indirect coverage changes

codecov[bot] avatar May 11 '24 09:05 codecov[bot]

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 10:05 mergify[bot]

/run-cpu-e2e

aoiasd avatar May 13 '24 02:05 aoiasd

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 05:05 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia, Yherealtita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 14 '24 02:05 sre-ci-robot

/lgtm

congqixia avatar May 14 '24 02:05 congqixia