milvus
milvus copied to clipboard
milvus-io
enhance: resource estimate improvement
issue: #32963
-
Add Exception to file class to avoid exception ignore.
-
Add GetResourceUsage method for index, column and segment.
-
Use bin log size but not mem size in CU of search and query.
-
Use in-use disk size in disk cache weight if segment is loaded.
-
Enable cache metric itself, remove redundant metric at search/query path.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Attention: Patch coverage is 70.79646% with 99 lines in your changes are missing coverage. Please review.
Project coverage is 82.08%. Comparing base (
8a9a421) to head (7935ad6). Report is 28 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32964 +/- ##
========================================
Coverage 82.07% 82.08%
========================================
Files 1007 999 -8
Lines 127647 128008 +361
========================================
+ Hits 104767 105074 +307
- Misses 18903 18960 +57
+ Partials 3977 3974 -3
| Files | Coverage Δ | |
|---|---|---|
| internal/core/src/common/Types.h | 31.45% <ø> (+3.43%) |
:arrow_up: |
| internal/core/src/index/Index.h | 100.00% <ø> (ø) |
|
| internal/core/src/index/InvertedIndexTantivy.cpp | 89.47% <100.00%> (ø) |
|
| internal/core/src/index/InvertedIndexTantivy.h | 47.36% <ø> (ø) |
|
| internal/core/src/index/ScalarIndexSort.cpp | 74.63% <100.00%> (+0.21%) |
:arrow_up: |
| internal/core/src/index/ScalarIndexSort.h | 57.14% <ø> (ø) |
|
| internal/core/src/index/StringIndexMarisa.h | 100.00% <ø> (ø) |
|
| internal/core/src/index/VectorDiskIndex.h | 18.18% <ø> (ø) |
|
| internal/core/src/index/VectorMemIndex.h | 100.00% <ø> (ø) |
|
| internal/core/src/segcore/SegmentGrowingImpl.h | 81.35% <100.00%> (+0.99%) |
:arrow_up: |
| ... and 31 more |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.