milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Remove fallback keys gen

Open sunby opened this issue 9 months ago • 3 comments

sunby avatar May 10 '24 09:05 sunby

@sunby

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar May 10 '24 09:05 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 10:05 mergify[bot]

/lgtm

jaime0815 avatar May 11 '24 07:05 jaime0815

New changes are detected. LGTM label has been removed.

sre-ci-robot avatar May 11 '24 08:05 sre-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 11 '24 08:05 sre-ci-robot

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 11:05 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 12 '24 10:05 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.10%. Comparing base (1e1fba0) to head (cffd507). Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32946      +/-   ##
==========================================
+ Coverage   81.84%   82.10%   +0.26%     
==========================================
  Files        1006     1007       +1     
  Lines      126941   127656     +715     
==========================================
+ Hits       103899   104817     +918     
+ Misses      19110    18884     -226     
- Partials     3932     3955      +23     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (+0.01%) :arrow_up:

... and 47 files with indirect coverage changes

codecov[bot] avatar May 12 '24 12:05 codecov[bot]

/run-cpu-e2e

jaime0815 avatar May 12 '24 12:05 jaime0815

/lgtm

jaime0815 avatar May 13 '24 02:05 jaime0815

/approve

congqixia avatar May 13 '24 05:05 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 13 '24 05:05 sre-ci-robot