milvus
milvus copied to clipboard
fix: two-phase retrieval on lru-segment
issue: #31822
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: longjiquan
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/hold
@longjiquan E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@longjiquan E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@longjiquan E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@longjiquan E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
Codecov Report
Attention: Patch coverage is 55.22388%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 82.11%. Comparing base (
293f14a
) to head (284191c
). Report is 29 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32945 +/- ##
==========================================
+ Coverage 82.06% 82.11% +0.05%
==========================================
Files 1007 999 -8
Lines 127699 127943 +244
==========================================
+ Hits 104793 105066 +273
+ Misses 18931 18905 -26
+ Partials 3975 3972 -3
Files | Coverage Δ | |
---|---|---|
...rnal/querynodev2/segments/default_limit_reducer.go | 100.00% <100.00%> (ø) |
|
internal/querynodev2/segments/reducer.go | 100.00% <100.00%> (ø) |
|
internal/querynodev2/tasks/query_task.go | 91.75% <100.00%> (+0.08%) |
:arrow_up: |
internal/querynodev2/segments/retrieve.go | 85.43% <86.66%> (+6.98%) |
:arrow_up: |
internal/querynodev2/segments/result.go | 74.04% <25.00%> (-0.72%) |
:arrow_down: |
internal/querynodev2/segments/segment_do.go | 38.88% <38.88%> (ø) |
/lgtm
@longjiquan E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, longjiquan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/querynodev2/segments/OWNERS~~ [czs007]
- ~~internal/querynodev2/tasks/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/unhold