milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: two-phase retrieval on lru-segment

Open longjiquan opened this issue 9 months ago • 11 comments

issue: #31822

longjiquan avatar May 10 '24 08:05 longjiquan

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: longjiquan To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 10 '24 08:05 sre-ci-robot

/hold

longjiquan avatar May 10 '24 08:05 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 08:05 mergify[bot]

/run-cpu-e2e

longjiquan avatar May 10 '24 08:05 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 09:05 mergify[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 09:05 mergify[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 09:05 mergify[bot]

/run-cpu-e2e

longjiquan avatar May 13 '24 09:05 longjiquan

Codecov Report

Attention: Patch coverage is 55.22388% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (293f14a) to head (284191c). Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32945      +/-   ##
==========================================
+ Coverage   82.06%   82.11%   +0.05%     
==========================================
  Files        1007      999       -8     
  Lines      127699   127943     +244     
==========================================
+ Hits       104793   105066     +273     
+ Misses      18931    18905      -26     
+ Partials     3975     3972       -3     
Files Coverage Δ
...rnal/querynodev2/segments/default_limit_reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/tasks/query_task.go 91.75% <100.00%> (+0.08%) :arrow_up:
internal/querynodev2/segments/retrieve.go 85.43% <86.66%> (+6.98%) :arrow_up:
internal/querynodev2/segments/result.go 74.04% <25.00%> (-0.72%) :arrow_down:
internal/querynodev2/segments/segment_do.go 38.88% <38.88%> (ø)

... and 217 files with indirect coverage changes

codecov[bot] avatar May 13 '24 11:05 codecov[bot]

/lgtm

aoiasd avatar May 13 '24 11:05 aoiasd

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 12:05 mergify[bot]

/run-cpu-e2e

longjiquan avatar May 14 '24 02:05 longjiquan

/approve /lgtm

czs007 avatar May 15 '24 09:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 15 '24 09:05 sre-ci-robot

/unhold

longjiquan avatar May 15 '24 09:05 longjiquan