milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: lru related issue fixup patch

Open chyezh opened this issue 9 months ago • 5 comments

issue: #32206, #32801

  • search failure with some assertion, segment not loaded and resource insufficient.

  • segment leak when query segments

chyezh avatar May 09 '24 14:05 chyezh

Codecov Report

Attention: Patch coverage is 87.50000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 82.04%. Comparing base (1e1fba0) to head (d506643). Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32916      +/-   ##
==========================================
+ Coverage   81.84%   82.04%   +0.20%     
==========================================
  Files        1006     1006              
  Lines      126941   127385     +444     
==========================================
+ Hits       103899   104519     +620     
+ Misses      19110    18892     -218     
- Partials     3932     3974      +42     
Files Coverage Δ
internal/querynodev2/tasks/query_task.go 91.66% <100.00%> (+0.45%) :arrow_up:
pkg/util/cache/cache.go 86.16% <100.00%> (+0.39%) :arrow_up:
pkg/util/syncutil/context_condition_variable.go 90.00% <100.00%> (ø)
internal/querynodev2/segments/manager.go 76.45% <83.33%> (-0.08%) :arrow_down:
internal/querynodev2/segments/retrieve.go 78.44% <91.66%> (-0.55%) :arrow_down:
internal/querynodev2/segments/segment_loader.go 73.49% <82.69%> (+2.26%) :arrow_up:

... and 15 files with indirect coverage changes

codecov[bot] avatar May 10 '24 04:05 codecov[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 05:05 mergify[bot]

/run-cpu-e2e

chyezh avatar May 10 '24 05:05 chyezh

/lgtm

sunby avatar May 10 '24 06:05 sunby

rerun ut

chyezh avatar May 10 '24 07:05 chyezh

/lgtm

sunby avatar May 10 '24 10:05 sunby

/approve

czs007 avatar May 10 '24 11:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 10 '24 11:05 sre-ci-robot