milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: support bitmap index for scalar type

Open zhagnlu opened this issue 9 months ago • 14 comments

#32900

zhagnlu avatar May 09 '24 09:05 zhagnlu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 09 '24 09:05 sre-ci-robot

Codecov Report

Attention: Patch coverage is 91.21813% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (acb0417) to head (c4a879e). Report is 86 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32902      +/-   ##
==========================================
+ Coverage   81.80%   82.08%   +0.28%     
==========================================
  Files        1006     1001       -5     
  Lines      126793   128215    +1422     
==========================================
+ Hits       103724   105248    +1524     
+ Misses      19135    18975     -160     
- Partials     3934     3992      +58     
Files Coverage Δ
pkg/util/indexparamcheck/bitmap_index_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/conf_adapter_mgr.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/index_type.go 100.00% <ø> (ø)
internal/core/src/index/BitmapIndex.h 77.77% <77.77%> (ø)
internal/core/src/index/IndexFactory.cpp 74.70% <66.66%> (+2.29%) :arrow_up:
internal/core/src/index/BitmapIndex.cpp 92.02% <92.02%> (ø)

... and 248 files with indirect coverage changes

codecov[bot] avatar May 09 '24 12:05 codecov[bot]

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 14:05 mergify[bot]

/lgtm

longjiquan avatar May 13 '24 01:05 longjiquan

/run-cpu-e2e

zhagnlu avatar May 13 '24 02:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 02:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 13 '24 04:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 07:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 13 '24 08:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 11:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 13 '24 11:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 11:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 13 '24 12:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 13:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 14 '24 02:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 03:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 14 '24 03:05 zhagnlu

/approve

czs007 avatar May 19 '24 13:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 19 '24 13:05 sre-ci-robot