milvus
milvus copied to clipboard
enhance: support bitmap index for scalar type
#32900
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Attention: Patch coverage is 91.21813%
with 31 lines
in your changes are missing coverage. Please review.
Project coverage is 82.08%. Comparing base (
acb0417
) to head (c4a879e
). Report is 86 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32902 +/- ##
==========================================
+ Coverage 81.80% 82.08% +0.28%
==========================================
Files 1006 1001 -5
Lines 126793 128215 +1422
==========================================
+ Hits 103724 105248 +1524
+ Misses 19135 18975 -160
- Partials 3934 3992 +58
Files | Coverage Δ | |
---|---|---|
pkg/util/indexparamcheck/bitmap_index_checker.go | 100.00% <100.00%> (ø) |
|
pkg/util/indexparamcheck/conf_adapter_mgr.go | 100.00% <100.00%> (ø) |
|
pkg/util/indexparamcheck/index_type.go | 100.00% <ø> (ø) |
|
internal/core/src/index/BitmapIndex.h | 77.77% <77.77%> (ø) |
|
internal/core/src/index/IndexFactory.cpp | 74.70% <66.66%> (+2.29%) |
:arrow_up: |
internal/core/src/index/BitmapIndex.cpp | 92.02% <92.02%> (ø) |
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/lgtm
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, zhagnlu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/core/OWNERS~~ [czs007]
- ~~pkg/util/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment