milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: remove duplicated data generation APIs for bulk insert test

Open cydrain opened this issue 9 months ago • 15 comments

Issue: #22837

including following changes:

  1. Add API CreateInsertData() and BuildArrayData() in internal/util/testutil
  2. Remove duplicated test APIs from importutilv2 unittest and bulk insert integration test

cydrain avatar May 09 '24 06:05 cydrain

/lgtm

bigsheeper avatar May 09 '24 06:05 bigsheeper

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 09 '24 07:05 mergify[bot]

/lgtm

bigsheeper avatar May 09 '24 08:05 bigsheeper

Codecov Report

Attention: Patch coverage is 96.17225% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 82.01%. Comparing base (1e1fba0) to head (48616f9). Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32889      +/-   ##
==========================================
+ Coverage   81.84%   82.01%   +0.16%     
==========================================
  Files        1006     1006              
  Lines      126941   127360     +419     
==========================================
+ Hits       103899   104450     +551     
+ Misses      19110    18936     -174     
- Partials     3932     3974      +42     
Files Coverage Δ
internal/util/testutil/test_util.go 96.05% <96.17%> (+1.31%) :arrow_up:

... and 25 files with indirect coverage changes

codecov[bot] avatar May 09 '24 10:05 codecov[bot]

/run-cpu-e2e

cydrain avatar May 09 '24 11:05 cydrain

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 09 '24 11:05 mergify[bot]

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 09 '24 11:05 mergify[bot]

/run-cpu-e2e

cydrain avatar May 10 '24 01:05 cydrain

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 02:05 mergify[bot]

/run-cpu-e2e

cydrain avatar May 10 '24 03:05 cydrain

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 10 '24 03:05 mergify[bot]

@cydrain

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar May 10 '24 04:05 mergify[bot]

/rerun ut

cydrain avatar May 10 '24 04:05 cydrain

/lgtm

bigsheeper avatar May 10 '24 07:05 bigsheeper

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 10 '24 07:05 sre-ci-robot