milvus
milvus copied to clipboard
enhance: remove duplicated data generation APIs for bulk insert test
Issue: #22837
including following changes:
- Add API CreateInsertData() and BuildArrayData() in internal/util/testutil
- Remove duplicated test APIs from importutilv2 unittest and bulk insert integration test
/lgtm
@cydrain ut workflow job failed, comment rerun ut
can trigger the job again.
/lgtm
Codecov Report
Attention: Patch coverage is 96.17225%
with 16 lines
in your changes are missing coverage. Please review.
Project coverage is 82.01%. Comparing base (
1e1fba0
) to head (48616f9
). Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32889 +/- ##
==========================================
+ Coverage 81.84% 82.01% +0.16%
==========================================
Files 1006 1006
Lines 126941 127360 +419
==========================================
+ Hits 103899 104450 +551
+ Misses 19110 18936 -174
- Partials 3932 3974 +42
Files | Coverage Δ | |
---|---|---|
internal/util/testutil/test_util.go | 96.05% <96.17%> (+1.31%) |
:arrow_up: |
/run-cpu-e2e
@cydrain E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@cydrain E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@cydrain E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@cydrain E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@cydrain
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
-
feat:
for introducing a new feature. -
fix:
for bug fixes. -
enhance:
for improvements to existing functionality. -
test
: for add tests to existing functionality. -
doc
: for modifying documentation. -
auto
: for the pull request from bot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type
is one of feat
, fix
, enhance
, test
or doc
.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
/rerun ut
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, cydrain
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment