milvus
milvus copied to clipboard
fix: Make compactor able to clear empty segments
See also: #32553
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
Codecov Report
Attention: Patch coverage is 80.76923%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 82.07%. Comparing base (
8a9a421
) to head (cb7fb9d
). Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32821 +/- ##
==========================================
- Coverage 82.07% 82.07% -0.01%
==========================================
Files 1007 1007
Lines 127647 127644 -3
==========================================
- Hits 104767 104763 -4
- Misses 18903 18907 +4
+ Partials 3977 3974 -3
Files | Coverage Δ | |
---|---|---|
internal/datanode/flow_graph_dd_node.go | 93.03% <90.00%> (+0.82%) |
:arrow_up: |
internal/datanode/compactor.go | 91.84% <75.00%> (+1.62%) |
:arrow_up: |
@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, XuanYang-cn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datanode/OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment