milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: [2.4]Validate num of rows for insert field data with schema (#32770)

Open congqixia opened this issue 9 months ago • 2 comments

Cherry-pick from master pr: #32770 See also #32769

congqixia avatar May 07 '24 02:05 congqixia

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.81%. Comparing base (71b4ca3) to head (99b29f9). Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32799      +/-   ##
==========================================
+ Coverage   81.78%   81.81%   +0.02%     
==========================================
  Files         998      998              
  Lines      124367   124415      +48     
==========================================
+ Hits       101717   101784      +67     
+ Misses      18784    18763      -21     
- Partials     3866     3868       +2     
Files Coverage Δ
internal/proxy/validate_util.go 91.40% <100.00%> (ø)
pkg/util/funcutil/func.go 91.45% <100.00%> (+1.75%) :arrow_up:

... and 31 files with indirect coverage changes

codecov[bot] avatar May 07 '24 07:05 codecov[bot]

/approve /lgtm

czs007 avatar May 07 '24 11:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 07 '24 11:05 sre-ci-robot