milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: avoid too many gorountines when calc distance

Open CocaineCong opened this issue 9 months ago • 11 comments

use gorountines pool to avoid too many gorountines be created.

CocaineCong avatar May 06 '24 06:05 CocaineCong

Welcome @CocaineCong! It looks like this is your first PR to milvus-io/milvus 🎉

sre-ci-robot avatar May 06 '24 06:05 sre-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CocaineCong To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 06 '24 06:05 sre-ci-robot

@CocaineCong Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar May 06 '24 06:05 mergify[bot]

@CocaineCong

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar May 06 '24 06:05 mergify[bot]

@CocaineCong E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 07:05 mergify[bot]

@CocaineCong thanks your contribution. you need to have a sign for the commit to pass the dco check. try to do:

git commit --amend -s

and then force to push it

SimFG avatar May 06 '24 07:05 SimFG

@CocaineCong ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 06 '24 13:05 mergify[bot]

@SimFG ok, finished! thanks u so much and PTAL.

CocaineCong avatar May 06 '24 16:05 CocaineCong

rerun ut

CocaineCong avatar May 07 '24 09:05 CocaineCong

Hello CocaineCong, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

github-actions[bot] avatar May 07 '24 09:05 github-actions[bot]

rerun ut

SimFG avatar May 07 '24 10:05 SimFG