milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Add Wrapper and Keepalive for CTraceContext ids

Open congqixia opened this issue 9 months ago • 7 comments

See also #32742

congqixia avatar Apr 30 '24 10:04 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 30 '24 10:04 sre-ci-robot

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 30 '24 10:04 mergify[bot]

/run-cpu-e2e

congqixia avatar Apr 30 '24 10:04 congqixia

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 30 '24 10:04 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 30 '24 10:04 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 30 '24 11:04 mergify[bot]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (600db9d) to head (ea62399). Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32746      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.05%     
==========================================
  Files        1001     1001              
  Lines      125359   125365       +6     
==========================================
- Hits       102508   102454      -54     
- Misses      18966    19021      +55     
- Partials     3885     3890       +5     
Files Coverage Δ
internal/querynodev2/segments/load_index_info.go 73.33% <100.00%> (+0.19%) :arrow_up:
internal/querynodev2/segments/trace.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment.go 67.08% <66.66%> (-0.01%) :arrow_down:

... and 34 files with indirect coverage changes

codecov[bot] avatar Apr 30 '24 12:04 codecov[bot]

/run-cpu-e2e

congqixia avatar May 06 '24 02:05 congqixia

/lgtm

longjiquan avatar May 06 '24 02:05 longjiquan

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 02:05 mergify[bot]

/run-cpu-e2e

congqixia avatar May 06 '24 05:05 congqixia

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 06:05 mergify[bot]

/lgtm

longjiquan avatar May 07 '24 02:05 longjiquan