milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: add more trace for search & query

Open longjiquan opened this issue 9 months ago • 3 comments

issue: https://github.com/milvus-io/milvus/issues/32728

longjiquan avatar Apr 30 '24 08:04 longjiquan

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 30 '24 08:04 mergify[bot]

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 30 '24 09:04 mergify[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 04:05 mergify[bot]

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 06 '24 04:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (83ce352) to head (99adcea). Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32734      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.06%     
==========================================
  Files        1001     1001              
  Lines      125359   125450      +91     
==========================================
+ Hits       102517   102519       +2     
- Misses      18956    19018      +62     
- Partials     3886     3913      +27     
Files Coverage Δ
internal/core/src/segcore/Reduce.cpp 93.18% <100.00%> (+0.13%) :arrow_up:
internal/core/src/segcore/Reduce.h 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)
internal/core/src/segcore/reduce_c.cpp 68.65% <100.00%> (+1.99%) :arrow_up:
internal/proxy/task_search.go 77.46% <100.00%> (+0.22%) :arrow_up:
internal/querynodev2/segments/reduce.go 75.90% <100.00%> (+0.29%) :arrow_up:
internal/querynodev2/segments/result.go 74.75% <100.00%> (+0.74%) :arrow_up:
internal/core/src/segcore/segment_c.cpp 57.79% <50.00%> (-0.23%) :arrow_down:
internal/core/src/segcore/SegmentInterface.cpp 88.50% <62.50%> (-0.39%) :arrow_down:

... and 27 files with indirect coverage changes

codecov[bot] avatar May 06 '24 05:05 codecov[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 06:05 mergify[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 07:05 mergify[bot]

/run-cpu-e2e

longjiquan avatar May 06 '24 08:05 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 07 '24 02:05 mergify[bot]

/approve /lgtm

czs007 avatar May 07 '24 03:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 07 '24 03:05 sre-ci-robot