milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Enhancement]: local reduce can be optimized if only one segment is involved

Open longjiquan opened this issue 9 months ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What would you like to be added?

https://github.com/milvus-io/milvus/blob/77f4f0c5a82f71c148a10e4719df48033dfd4d6c/internal/core/src/segcore/Reduce.cpp#L222-L311

Why is this needed?

9PfCtXlffP

If only one segment was involved in the reduce phase, in fact we waste the cpu of heap-sort to complete the reduce. We can do it more simply.

Anything else?

No response

longjiquan avatar Apr 30 '24 06:04 longjiquan

the tracing can be found in https://github.com/milvus-io/milvus/pull/32734

longjiquan avatar Apr 30 '24 08:04 longjiquan

seems to be a promising optimization

xiaofan-luan avatar May 05 '24 03:05 xiaofan-luan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 05 '24 01:06 stale[bot]