milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Add channelCPs in FlushResponse

Open wayblink opened this issue 9 months ago • 10 comments

#32609

wayblink avatar Apr 28 '24 12:04 wayblink

@wayblink Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '24 13:04 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 29 '24 06:04 mergify[bot]

/run-cpu-e2e

czs007 avatar Apr 29 '24 06:04 czs007

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 29 '24 06:04 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 29 '24 07:04 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 29 '24 08:04 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 08 '24 09:05 mergify[bot]

rerun ut

wayblink avatar May 08 '24 11:05 wayblink

rerun ut

wayblink avatar May 08 '24 13:05 wayblink

rerun ut

czs007 avatar May 09 '24 09:05 czs007

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 09 '24 13:05 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.12%. Comparing base (2facf61) to head (e126b27). Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #32683      +/-   ##
==========================================
+ Coverage   83.10%   83.12%   +0.01%     
==========================================
  Files         850      850              
  Lines      106557   106614      +57     
==========================================
+ Hits        88555    88623      +68     
+ Misses      14704    14694      -10     
+ Partials     3298     3297       -1     
Files Coverage Δ
internal/datacoord/meta.go 89.74% <100.00%> (-0.21%) :arrow_down:
internal/datacoord/server.go 71.86% <100.00%> (-0.42%) :arrow_down:
internal/datacoord/services.go 86.31% <100.00%> (+0.18%) :arrow_up:
internal/proxy/task.go 87.44% <100.00%> (+0.03%) :arrow_up:
internal/rootcoord/broker.go 90.75% <100.00%> (+0.05%) :arrow_up:

... and 19 files with indirect coverage changes

codecov[bot] avatar May 09 '24 14:05 codecov[bot]

/approve /lgtm

czs007 avatar May 10 '24 01:05 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 10 '24 01:05 sre-ci-robot

pr: https://github.com/milvus-io/milvus/pull/32044

czs007 avatar May 10 '24 01:05 czs007