milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: Support sparse float vector bulk insert for binlog/json/parquet

Open cydrain opened this issue 9 months ago • 8 comments

Issue: #22837

cydrain avatar Apr 26 '24 08:04 cydrain

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cydrain To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 26 '24 08:04 sre-ci-robot

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 08:04 mergify[bot]

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 08:04 mergify[bot]

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 09:04 mergify[bot]

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 09:04 mergify[bot]

@cydrain ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 10:04 mergify[bot]

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '24 11:04 mergify[bot]

issue: #29419

zhengbuqian avatar Apr 28 '24 02:04 zhengbuqian

Codecov Report

Attention: Patch coverage is 71.60494% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (ccce1e9) to head (1ee5d37). Report is 72 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32649      +/-   ##
==========================================
- Coverage   81.82%   81.74%   -0.08%     
==========================================
  Files         990      998       +8     
  Lines      124483   124083     -400     
==========================================
- Hits       101852   101432     -420     
- Misses      18767    18783      +16     
- Partials     3864     3868       +4     
Files Coverage Δ
internal/storage/insert_data.go 90.00% <100.00%> (+1.66%) :arrow_up:
internal/util/importutilv2/numpy/field_reader.go 61.02% <100.00%> (+0.20%) :arrow_up:
internal/util/importutilv2/parquet/util.go 72.51% <100.00%> (-1.09%) :arrow_down:
internal/util/importutilv2/json/row_parser.go 46.08% <52.38%> (+0.52%) :arrow_up:
internal/util/importutilv2/parquet/field_reader.go 47.67% <76.78%> (+2.61%) :arrow_up:

... and 216 files with indirect coverage changes

codecov[bot] avatar Apr 28 '24 05:04 codecov[bot]

/lgtm

bigsheeper avatar May 07 '24 09:05 bigsheeper

/hold

cydrain avatar May 07 '24 10:05 cydrain

/unhold

cydrain avatar May 07 '24 10:05 cydrain

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 07 '24 10:05 sre-ci-robot