milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: refactor segcore plan executor module

Open zhagnlu opened this issue 10 months ago • 28 comments

#32636

zhagnlu avatar Apr 26 '24 05:04 zhagnlu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu To complete the pull request process, please assign wxyucs after the PR has been reviewed. You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 26 '24 05:04 sre-ci-robot

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '24 05:04 mergify[bot]

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 05:04 mergify[bot]

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 06 '24 10:05 mergify[bot]

rerun ut

zhagnlu avatar May 09 '24 11:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 09 '24 14:05 mergify[bot]

rerun ut

zhagnlu avatar May 10 '24 02:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 07:05 mergify[bot]

rerun ut

zhagnlu avatar May 11 '24 07:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 09:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 13 '24 11:05 zhagnlu

rerun ut

zhagnlu avatar May 13 '24 11:05 zhagnlu

rerun ut

zhagnlu avatar May 13 '24 12:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 13:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 70.98540% with 159 lines in your changes missing coverage. Please review.

Project coverage is 83.53%. Comparing base (7763718) to head (376ea42). Report is 224 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32637      +/-   ##
==========================================
+ Coverage   82.12%   83.53%   +1.40%     
==========================================
  Files        1015      998      -17     
  Lines      129767   127576    -2191     
==========================================
- Hits       106574   106569       -5     
+ Misses      19231    17024    -2207     
- Partials     3962     3983      +21     
Files Coverage Δ
internal/core/src/bitset/bitset.h 98.63% <ø> (+5.70%) :arrow_up:
internal/core/src/common/Types.h 31.45% <ø> (+3.43%) :arrow_up:
internal/core/src/common/Utils.h 90.00% <100.00%> (+0.57%) :arrow_up:
internal/core/src/common/Vector.h 100.00% <100.00%> (ø)
internal/core/src/exec/QueryContext.h 85.29% <100.00%> (+5.29%) :arrow_up:
internal/core/src/exec/operator/CountNode.cpp 100.00% <100.00%> (ø)
internal/core/src/exec/operator/FilterBits.cpp 96.61% <100.00%> (+2.86%) :arrow_up:
...nternal/core/src/exec/operator/GroupByOperator.cpp 96.42% <ø> (ø)
internal/core/src/exec/operator/GroupByOperator.h 79.24% <ø> (ø)
internal/core/src/expr/ITypeExpr.h 51.12% <ø> (+6.07%) :arrow_up:
... and 33 more

... and 179 files with indirect coverage changes

codecov[bot] avatar May 13 '24 14:05 codecov[bot]

/run-cpu-e2e

zhagnlu avatar May 14 '24 06:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 14 '24 09:05 mergify[bot]

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 15 '24 03:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 15 '24 06:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 15 '24 07:05 mergify[bot]

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 15 '24 13:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 16 '24 06:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 16 '24 06:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 21 '24 07:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 24 '24 10:05 mergify[bot]

/run-cpu-e2e

zhagnlu avatar May 27 '24 06:05 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 30 '24 07:05 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 29 '24 10:06 stale[bot]