milvus
milvus copied to clipboard
enhance: refactor segcore plan executor module
#32636
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@zhagnlu ut workflow job failed, comment rerun ut
can trigger the job again.
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
rerun ut
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
rerun ut
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
rerun ut
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
rerun ut
rerun ut
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
Codecov Report
Attention: Patch coverage is 70.98540%
with 159 lines
in your changes missing coverage. Please review.
Project coverage is 83.53%. Comparing base (
7763718
) to head (376ea42
). Report is 224 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32637 +/- ##
==========================================
+ Coverage 82.12% 83.53% +1.40%
==========================================
Files 1015 998 -17
Lines 129767 127576 -2191
==========================================
- Hits 106574 106569 -5
+ Misses 19231 17024 -2207
- Partials 3962 3983 +21
Files | Coverage Δ | |
---|---|---|
internal/core/src/bitset/bitset.h | 98.63% <ø> (+5.70%) |
:arrow_up: |
internal/core/src/common/Types.h | 31.45% <ø> (+3.43%) |
:arrow_up: |
internal/core/src/common/Utils.h | 90.00% <100.00%> (+0.57%) |
:arrow_up: |
internal/core/src/common/Vector.h | 100.00% <100.00%> (ø) |
|
internal/core/src/exec/QueryContext.h | 85.29% <100.00%> (+5.29%) |
:arrow_up: |
internal/core/src/exec/operator/CountNode.cpp | 100.00% <100.00%> (ø) |
|
internal/core/src/exec/operator/FilterBits.cpp | 96.61% <100.00%> (+2.86%) |
:arrow_up: |
...nternal/core/src/exec/operator/GroupByOperator.cpp | 96.42% <ø> (ø) |
|
internal/core/src/exec/operator/GroupByOperator.h | 79.24% <ø> (ø) |
|
internal/core/src/expr/ITypeExpr.h | 51.12% <ø> (+6.07%) |
:arrow_up: |
... and 33 more |
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.