milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Apply node-indexing and cache optimization for channel dist

Open congqixia opened this issue 10 months ago • 7 comments

See also #32165

congqixia avatar Apr 25 '24 03:04 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 25 '24 03:04 sre-ci-robot

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 03:04 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 04:04 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 06:04 mergify[bot]

/run-cpu-e2e

congqixia avatar Apr 25 '24 06:04 congqixia

Codecov Report

Attention: Patch coverage is 71.42857% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (9a719ec) to head (9436332). Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32595      +/-   ##
==========================================
+ Coverage   81.76%   81.79%   +0.02%     
==========================================
  Files         998      998              
  Lines      124037   124080      +43     
==========================================
+ Hits       101418   101487      +69     
+ Misses      18757    18742      -15     
+ Partials     3862     3851      -11     
Files Coverage Δ
internal/querycoordv2/meta/channel_dist_manager.go 83.33% <71.42%> (-13.06%) :arrow_down:

... and 38 files with indirect coverage changes

codecov[bot] avatar Apr 25 '24 07:04 codecov[bot]

/lgtm

tedxu avatar Apr 26 '24 06:04 tedxu

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 28 '24 04:04 mergify[bot]

/run-cpu-e2e

congqixia avatar Apr 28 '24 04:04 congqixia

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '24 05:04 mergify[bot]

/lgtm

tedxu avatar Apr 28 '24 08:04 tedxu