milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: LRU cache implementation

Open sunby opened this issue 10 months ago • 26 comments

This pr is the implementation of lru cache on branch lru-dev.

sunby avatar Apr 24 '24 08:04 sunby

@sunby

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Apr 24 '24 08:04 mergify[bot]

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Apr 24 '24 08:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 08:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '24 08:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 08:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 11:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '24 11:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 03:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 04:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 06:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 06:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 08:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '24 11:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 07:04 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 07:04 mergify[bot]

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '24 08:04 mergify[bot]

/run-cpu-e2e

sunby avatar Apr 26 '24 08:04 sunby

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '24 08:04 mergify[bot]

/run-cpu-e2e

sunby avatar Apr 26 '24 09:04 sunby

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '24 10:04 mergify[bot]

/approve

xiaofan-luan avatar Apr 26 '24 15:04 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 26 '24 15:04 sre-ci-robot

there are still many issues to improve. but let's merge this pr for further test

xiaofan-luan avatar Apr 26 '24 15:04 xiaofan-luan

let's fix the ut issue, merge this and see

xiaofan-luan avatar Apr 26 '24 15:04 xiaofan-luan

Codecov Report

Attention: Patch coverage is 73.69942% with 364 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (ccce1e9) to head (14abec2). Report is 49 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32567      +/-   ##
==========================================
- Coverage   81.82%   81.74%   -0.08%     
==========================================
  Files         990      992       +2     
  Lines      124483   125427     +944     
==========================================
+ Hits       101852   102531     +679     
- Misses      18767    18999     +232     
- Partials     3864     3897      +33     
Files Coverage Δ
internal/core/src/segcore/ConcurrentVector.h 95.65% <100.00%> (+0.03%) :arrow_up:
internal/core/src/segcore/InsertRecord.h 90.98% <ø> (ø)
internal/core/src/segcore/Reduce.cpp 92.94% <100.00%> (+10.36%) :arrow_up:
internal/core/src/segcore/Reduce.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 80.00% <ø> (ø)
internal/core/src/segcore/StreamReduce.h 100.00% <100.00%> (ø)
internal/core/src/segcore/Utils.cpp 75.00% <100.00%> (+1.31%) :arrow_up:
internal/core/src/segcore/Utils.h 100.00% <100.00%> (ø)
internal/core/src/segcore/pkVisitor.h 25.00% <ø> (ø)
internal/core/src/storage/prometheus_client.h 100.00% <ø> (ø)
... and 35 more

... and 49 files with indirect coverage changes

codecov[bot] avatar Apr 28 '24 05:04 codecov[bot]

@sunby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Apr 28 '24 08:04 mergify[bot]

/lgtm

chyezh avatar May 06 '24 12:05 chyezh