milvus
milvus copied to clipboard
feat: LRU cache implementation
This pr is the implementation of lru cache on branch lru-dev.
@sunby
Invalid PR Title Format Detected
Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
- Title Format: The PR title must begin with one of these prefixes:
-
feat:
for introducing a new feature. -
fix:
for bug fixes. -
enhance:
for improvements to existing functionality. -
test
: for add tests to existing functionality. -
doc
: for modifying documentation. -
auto
: for the pull request from bot.
- Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.
Required Title Structure:
[Type]: [Description of the PR]
Where Type
is one of feat
, fix
, enhance
, test
or doc
.
Example:
enhance: improve search performance significantly
Please review and update your PR to comply with these guidelines.
@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby ut workflow job failed, comment rerun ut
can trigger the job again.
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@sunby E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sunby, xiaofan-luan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [xiaofan-luan]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
there are still many issues to improve. but let's merge this pr for further test
let's fix the ut issue, merge this and see
Codecov Report
Attention: Patch coverage is 73.69942%
with 364 lines
in your changes are missing coverage. Please review.
Project coverage is 81.74%. Comparing base (
ccce1e9
) to head (14abec2
). Report is 49 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32567 +/- ##
==========================================
- Coverage 81.82% 81.74% -0.08%
==========================================
Files 990 992 +2
Lines 124483 125427 +944
==========================================
+ Hits 101852 102531 +679
- Misses 18767 18999 +232
- Partials 3864 3897 +33
Files | Coverage Δ | |
---|---|---|
internal/core/src/segcore/ConcurrentVector.h | 95.65% <100.00%> (+0.03%) |
:arrow_up: |
internal/core/src/segcore/InsertRecord.h | 90.98% <ø> (ø) |
|
internal/core/src/segcore/Reduce.cpp | 92.94% <100.00%> (+10.36%) |
:arrow_up: |
internal/core/src/segcore/Reduce.h | 100.00% <ø> (ø) |
|
internal/core/src/segcore/SegmentSealedImpl.h | 80.00% <ø> (ø) |
|
internal/core/src/segcore/StreamReduce.h | 100.00% <100.00%> (ø) |
|
internal/core/src/segcore/Utils.cpp | 75.00% <100.00%> (+1.31%) |
:arrow_up: |
internal/core/src/segcore/Utils.h | 100.00% <100.00%> (ø) |
|
internal/core/src/segcore/pkVisitor.h | 25.00% <ø> (ø) |
|
internal/core/src/storage/prometheus_client.h | 100.00% <ø> (ø) |
|
... and 35 more |
@sunby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
/lgtm