milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Bug]: AssignSegmentID still return success when it failed

Open zhagnlu opened this issue 10 months ago • 6 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Environment

- Milvus version: master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

when datacoord alloc segmentid failed, this interface return success instead of fail. image

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

zhagnlu avatar Apr 16 '24 09:04 zhagnlu

image ut breaks

XuanYang-cn avatar Apr 17 '24 06:04 XuanYang-cn

@zhagnlu list of SegmentIDRequest represents different collection's segmentIDRequests, One Collection's failure shouldn't influence other collections.

As how proxy processing it, image

we should append a SegmentAllocations with Non-success status image

XuanYang-cn avatar Apr 17 '24 06:04 XuanYang-cn

It looks like the patch broke the design for proxy may assign segment id for multiple collections /cc @czs007

congqixia avatar Apr 17 '24 06:04 congqixia

/assign @zhagnlu /assign @czs007

XuanYang-cn avatar Apr 17 '24 06:04 XuanYang-cn

also we don't return err for RPC returns, but error status

XuanYang-cn avatar Apr 17 '24 06:04 XuanYang-cn

update it as return error status for every request, not return err all

zhagnlu avatar Apr 17 '24 07:04 zhagnlu