milvus
milvus copied to clipboard
enhance: support null in go payload
#31728
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/lgtm
Codecov Report
Attention: Patch coverage is 84.70418%
with 106 lines
in your changes missing coverage. Please review.
Project coverage is 81.02%. Comparing base (
5fac2fa
) to head (40fecf1
). Report is 4 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32296 +/- ##
==========================================
+ Coverage 80.89% 81.02% +0.12%
==========================================
Files 1063 1056 -7
Lines 136139 136771 +632
==========================================
+ Hits 110136 110816 +680
+ Misses 21817 21736 -81
- Partials 4186 4219 +33
Files | Coverage Δ | |
---|---|---|
internal/core/src/storage/Event.cpp | 81.12% <100.00%> (-0.28%) |
:arrow_down: |
internal/core/src/storage/Event.h | 83.33% <ø> (+13.33%) |
:arrow_up: |
internal/core/src/storage/InsertData.cpp | 84.61% <100.00%> (+0.30%) |
:arrow_up: |
internal/core/src/storage/PayloadReader.cpp | 100.00% <ø> (ø) |
|
internal/storage/binlog_reader.go | 92.72% <100.00%> (ø) |
|
internal/storage/binlog_writer.go | 85.00% <100.00%> (+0.09%) |
:arrow_up: |
internal/storage/event_data.go | 92.95% <100.00%> (+0.03%) |
:arrow_up: |
internal/storage/event_reader.go | 100.00% <100.00%> (ø) |
|
internal/storage/event_writer.go | 83.08% <100.00%> (ø) |
|
internal/storage/insert_data.go | 90.37% <100.00%> (+1.13%) |
:arrow_up: |
... and 10 more |
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon ut workflow job failed, comment rerun ut
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon ut workflow job failed, comment rerun ut
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
rerun ut
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
keep this still reviewing
@smellthemoon ut workflow job failed, comment rerun ut
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
rerun ut
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon ut workflow job failed, comment rerun ut
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.