milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: support null in go payload

Open smellthemoon opened this issue 10 months ago • 21 comments

#31728

smellthemoon avatar Apr 16 '24 03:04 smellthemoon

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 16 '24 03:04 sre-ci-robot

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 03:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 16 '24 07:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 07:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 08:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 09:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 11:04 mergify[bot]

/lgtm

tedxu avatar Apr 17 '24 03:04 tedxu

Codecov Report

Attention: Patch coverage is 84.70418% with 106 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (5fac2fa) to head (40fecf1). Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32296      +/-   ##
==========================================
+ Coverage   80.89%   81.02%   +0.12%     
==========================================
  Files        1063     1056       -7     
  Lines      136139   136771     +632     
==========================================
+ Hits       110136   110816     +680     
+ Misses      21817    21736      -81     
- Partials     4186     4219      +33     
Files Coverage Δ
internal/core/src/storage/Event.cpp 81.12% <100.00%> (-0.28%) :arrow_down:
internal/core/src/storage/Event.h 83.33% <ø> (+13.33%) :arrow_up:
internal/core/src/storage/InsertData.cpp 84.61% <100.00%> (+0.30%) :arrow_up:
internal/core/src/storage/PayloadReader.cpp 100.00% <ø> (ø)
internal/storage/binlog_reader.go 92.72% <100.00%> (ø)
internal/storage/binlog_writer.go 85.00% <100.00%> (+0.09%) :arrow_up:
internal/storage/event_data.go 92.95% <100.00%> (+0.03%) :arrow_up:
internal/storage/event_reader.go 100.00% <100.00%> (ø)
internal/storage/event_writer.go 83.08% <100.00%> (ø)
internal/storage/insert_data.go 90.37% <100.00%> (+1.13%) :arrow_up:
... and 10 more

... and 231 files with indirect coverage changes

codecov[bot] avatar Apr 17 '24 03:04 codecov[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 19 '24 17:04 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 22 '24 11:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 22 '24 12:04 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 23 '24 05:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 06:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 07:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 23 '24 08:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 09:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 13:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 03:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 03:04 mergify[bot]

rerun ut

smellthemoon avatar Apr 26 '24 03:04 smellthemoon

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar May 26 '24 23:05 stale[bot]

keep this still reviewing

congqixia avatar May 27 '24 10:05 congqixia

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 27 '24 10:05 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '24 04:05 mergify[bot]

/run-cpu-e2e

smellthemoon avatar May 28 '24 05:05 smellthemoon

rerun ut

smellthemoon avatar Jun 11 '24 13:06 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 13 '24 03:06 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 13 '24 14:06 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 13 '24 14:06 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 18 '24 07:06 mergify[bot]