milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Add placeholder type check in proxy search task

Open congqixia opened this issue 10 months ago • 5 comments

See also #31766

This PR add param place holder type check with search vector field type. This utility method also allows future float32, float16 and bfloat16 convertion.

congqixia avatar Apr 01 '24 07:04 congqixia

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 01 '24 08:04 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 01 '24 08:04 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 01 '24 08:04 sre-ci-robot

Codecov Report

Attention: Patch coverage is 86.53846% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.13%. Comparing base (92c84cc) to head (bba992f). Report is 240 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31786      +/-   ##
==========================================
+ Coverage   81.03%   81.13%   +0.10%     
==========================================
  Files         979      979              
  Lines      140698   140744      +46     
==========================================
+ Hits       114017   114196     +179     
+ Misses      22881    22754     -127     
+ Partials     3800     3794       -6     
Files Coverage Δ
internal/proxy/meta_cache.go 93.01% <100.00%> (+0.02%) :arrow_up:
internal/proxy/task_search.go 83.36% <100.00%> (ø)
pkg/util/typeutil/schema.go 84.27% <90.90%> (+0.06%) :arrow_up:
internal/proxy/search_util.go 72.50% <82.85%> (+2.18%) :arrow_up:

... and 40 files with indirect coverage changes

codecov[bot] avatar Apr 01 '24 11:04 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar May 03 '24 11:05 stale[bot]