milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Check Segment equal before releasing old version segment

Open congqixia opened this issue 1 year ago • 6 comments

Segment manager check segment manager when replacing segment with same id. If the new segment has lower or equal version comparing to the existing one, the new segment will be released.

This PR prevent releasing the segment whe putting the same segment into segment manager.

congqixia avatar Feb 21 '24 12:02 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Feb 21 '24 12:02 sre-ci-robot

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.93%. Comparing base (0c868b6) to head (d27d727). Report is 259 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30741      +/-   ##
==========================================
- Coverage   80.95%   80.93%   -0.02%     
==========================================
  Files         977      977              
  Lines      138781   138783       +2     
==========================================
- Hits       112353   112330      -23     
- Misses      22671    22710      +39     
+ Partials     3757     3743      -14     
Files Coverage Δ
internal/querynodev2/segments/manager.go 82.27% <0.00%> (+1.67%) :arrow_up:

... and 30 files with indirect coverage changes

codecov[bot] avatar Feb 23 '24 02:02 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Mar 24 '24 10:03 stale[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 25 '24 09:03 mergify[bot]

/run-cpu-e2e

congqixia avatar Mar 25 '24 10:03 congqixia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Apr 26 '24 00:04 stale[bot]