milvus icon indicating copy to clipboard operation
milvus copied to clipboard

wip: L2 compact

Open wayblink opened this issue 1 year ago • 48 comments

#30633

wayblink avatar Feb 02 '24 03:02 wayblink

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Feb 02 '24 03:02 sre-ci-robot

⚠️ The sha of the head commit of this PR conflicts with #30286. Mergify cannot evaluate rules on this PR. ⚠️

mergify[bot] avatar Feb 02 '24 03:02 mergify[bot]

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Feb 02 '24 07:02 mergify[bot]

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Feb 02 '24 07:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 02 '24 08:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 02 '24 08:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 03 '24 05:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 04 '24 06:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 04 '24 07:02 mergify[bot]

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Feb 04 '24 09:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 04 '24 09:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 04 '24 10:02 mergify[bot]

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Feb 04 '24 10:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 04 '24 10:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 04 '24 10:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 04 '24 12:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 05 '24 08:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 05 '24 08:02 mergify[bot]

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar Feb 05 '24 10:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 18 '24 06:02 mergify[bot]

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Feb 21 '24 12:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 21 '24 13:02 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 22 '24 08:02 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 06 '24 04:03 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 06 '24 05:03 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 06 '24 08:03 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 06 '24 11:03 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 06 '24 14:03 mergify[bot]

Codecov Report

Attention: Patch coverage is 15.50759% with 1057 lines in your changes are missing coverage. Please review.

Project coverage is 80.31%. Comparing base (0c868b6) to head (7169b0e). Report is 259 commits behind head on master.

:exclamation: Current head 7169b0e differs from pull request most recent head 90b7be1. Consider uploading reports for the commit 90b7be1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30458      +/-   ##
==========================================
- Coverage   80.95%   80.31%   -0.64%     
==========================================
  Files         977      977              
  Lines      138781   143141    +4360     
==========================================
+ Hits       112353   114967    +2614     
- Misses      22671    24307    +1636     
- Partials     3757     3867     +110     
Files Coverage Δ
internal/datacoord/server.go 73.07% <100.00%> (+0.59%) :arrow_up:
internal/datacoord/services.go 85.11% <100.00%> (+0.93%) :arrow_up:
internal/datanode/compactor.go 87.36% <100.00%> (-1.03%) :arrow_down:
internal/datanode/compactor_common.go 100.00% <100.00%> (ø)
internal/metastore/catalog.go 100.00% <ø> (ø)
pkg/common/common.go 80.00% <ø> (+7.58%) :arrow_up:
pkg/util/merr/errors.go 85.71% <ø> (ø)
pkg/util/paramtable/component_param.go 98.40% <100.00%> (+0.03%) :arrow_up:
pkg/util/typeutil/schema.go 84.00% <100.00%> (+0.19%) :arrow_up:
internal/storage/binlog_iterator.go 88.88% <77.77%> (-2.03%) :arrow_down:
... and 13 more

... and 302 files with indirect coverage changes

codecov[bot] avatar Mar 06 '24 16:03 codecov[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 11 '24 11:03 mergify[bot]