milvus
milvus copied to clipboard
enhance: support upsert autoid==true
related with: #29258
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon ut workflow job failed, comment rerun ut
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
Codecov Report
Attention: Patch coverage is 80.00000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 79.74%. Comparing base (
eae4dfc
) to head (364b96c
). Report is 19 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #30342 +/- ##
==========================================
- Coverage 84.35% 79.74% -4.61%
==========================================
Files 858 1127 +269
Lines 115248 139423 +24175
==========================================
+ Hits 97212 111177 +13965
- Misses 13734 23940 +10206
- Partials 4302 4306 +4
Files | Coverage Δ | |
---|---|---|
internal/proxy/task_insert.go | 76.21% <100.00%> (ø) |
|
internal/proxy/task_upsert.go | 73.33% <100.00%> (ø) |
|
internal/proxy/util.go | 91.23% <78.57%> (+1.39%) |
:arrow_up: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
/reopen
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
/reopen
@smellthemoon: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/run-cpu-e2e
@czs007 could you pls accelerate the review? thx
@czs007 could you pls accelerate the review? thx
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: smellthemoon, xiaofan-luan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/proxy/OWNERS~~ [xiaofan-luan]
- ~~tests/OWNERS~~ [xiaofan-luan]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment