milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Bug]: garbage collector may recycle file by mistake if `List` operations exceeds `missingTolerance`

Open congqixia opened this issue 1 year ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Environment

- Milvus version: v2.3.0 & v2.2.14
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

garbage collector may recycle file by mistake if List operations exceeds missingTolerance

Expected Behavior

garbage collector shall treat files correctly even the List operation costs lots of time

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

congqixia avatar Sep 19 '23 06:09 congqixia

  • [x] Fix garbage collector logic
    • [x] master #27203
    • [x] 2.3.1 #27204
    • [x] 2.2.x #27205
  • [x] Add metrics for garbage collector #27303

congqixia avatar Sep 21 '23 07:09 congqixia

Wait for release

  • [x] v2.3.1
  • [x] v2.2.15

congqixia avatar Sep 25 '23 02:09 congqixia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Dec 16 '23 18:12 stale[bot]

@congqixia Any followups for improving list performance?

xiaofan-luan avatar Dec 17 '23 13:12 xiaofan-luan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 15 '24 16:06 stale[bot]