milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Feature] enable max result window limit of query

Open chyezh opened this issue 1 year ago • 4 comments

enable max result window limit of query Related Issue: https://github.com/milvus-io/milvus/issues/24611

chyezh avatar Jun 08 '23 13:06 chyezh

@chyezh Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Jun 08 '23 13:06 mergify[bot]

Codecov Report

Merging #24768 (9f22973) into 2.2.0 (49630dc) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24768      +/-   ##
==========================================
- Coverage   80.67%   80.67%   -0.01%     
==========================================
  Files         760      760              
  Lines      106988   107006      +18     
==========================================
+ Hits        86314    86325      +11     
- Misses      17358    17362       +4     
- Partials     3316     3319       +3     
Impacted Files Coverage Δ
internal/proxy/task_query.go 69.71% <100.00%> (-0.54%) :arrow_down:
internal/proxy/util.go 91.48% <100.00%> (-0.25%) :arrow_down:
internal/util/paramtable/quota_param.go 71.38% <100.00%> (+0.14%) :arrow_up:

... and 21 files with indirect coverage changes

codecov[bot] avatar Jun 08 '23 14:06 codecov[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 08 '23 14:06 mergify[bot]

/lgtm

bigsheeper avatar Jun 09 '23 02:06 bigsheeper

rename the maxResultWindow into maxQueryResultWindow

chyezh avatar Jun 09 '23 02:06 chyezh

/lgtm

bigsheeper avatar Jun 09 '23 02:06 bigsheeper

/run-cpu-e2e

chyezh avatar Jun 09 '23 03:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 03:06 mergify[bot]

/run-cpu-e2e

chyezh avatar Jun 09 '23 03:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 03:06 mergify[bot]

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 04:06 mergify[bot]

/run-cpu-e2e

chyezh avatar Jun 09 '23 04:06 chyezh

/assign @czs007

chyezh avatar Jun 09 '23 05:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 06:06 mergify[bot]

/run-cpu-e2e

chyezh avatar Jun 09 '23 06:06 chyezh

/run-cpu-e2e

chyezh avatar Jun 09 '23 06:06 chyezh

/run-cpu-e2e

chyezh avatar Jun 09 '23 07:06 chyezh

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 07:06 mergify[bot]

manual pass for one of pipeline passed

yanliang567 avatar Jun 09 '23 07:06 yanliang567

/approve

czs007 avatar Jun 09 '23 07:06 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 09 '23 07:06 sre-ci-robot