milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix load collection failed after drop partition (#24680)

Open longjiquan opened this issue 1 year ago • 2 comments

issue: https://github.com/milvus-io/milvus/issues/24486

/kind bug

longjiquan avatar Jun 08 '23 12:06 longjiquan

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 08 '23 13:06 mergify[bot]

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 09 '23 04:06 mergify[bot]

@longjiquan, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

mergify[bot] avatar Jun 09 '23 07:06 mergify[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 08:06 mergify[bot]

/run-cpu-e2e

longjiquan avatar Jun 09 '23 08:06 longjiquan

Codecov Report

Merging #24766 (d43ed2f) into 2.2.0 (3f8777d) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head d43ed2f differs from pull request most recent head 3d28511. Consider uploading reports for the commit 3d28511 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24766      +/-   ##
==========================================
- Coverage   80.66%   80.65%   -0.01%     
==========================================
  Files         760      760              
  Lines      107005   107032      +27     
==========================================
+ Hits        86314    86329      +15     
- Misses      17366    17384      +18     
+ Partials     3325     3319       -6     
Impacted Files Coverage Δ
internal/querycoordv2/meta/collection_manager.go 78.37% <100.00%> (+1.84%) :arrow_up:
internal/querycoordv2/meta/coordinator_broker.go 68.71% <100.00%> (+3.93%) :arrow_up:
internal/querycoordv2/server.go 77.54% <100.00%> (+0.75%) :arrow_up:

... and 18 files with indirect coverage changes

codecov[bot] avatar Jun 09 '23 08:06 codecov[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 09 '23 09:06 mergify[bot]

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 11 '23 04:06 mergify[bot]

Let's make it into 2.2.10

xiaofan-luan avatar Jun 11 '23 15:06 xiaofan-luan

/run-cpu-e2e

longjiquan avatar Jun 12 '23 01:06 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 12 '23 02:06 mergify[bot]

/run-cpu-e2e

longjiquan avatar Jun 12 '23 02:06 longjiquan

/approve /lgtm

czs007 avatar Jun 12 '23 06:06 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 12 '23 06:06 sre-ci-robot