milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Cherry-Pick] Remove unused iterator initialization

Open congqixia opened this issue 1 year ago • 5 comments

Cherry-pick from master /kind improvement

congqixia avatar Jun 08 '23 08:06 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 08 '23 08:06 sre-ci-robot

/lgtm

jiaoew1991 avatar Jun 08 '23 08:06 jiaoew1991

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 08 '23 09:06 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 08 '23 09:06 mergify[bot]

Codecov Report

Merging #24758 (39240a5) into 2.2.0 (a03ebcf) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            2.2.0   #24758   +/-   ##
=======================================
  Coverage   80.67%   80.68%           
=======================================
  Files         760      760           
  Lines      106999   106998    -1     
=======================================
+ Hits        86320    86329    +9     
+ Misses      17357    17355    -2     
+ Partials     3322     3314    -8     
Impacted Files Coverage Δ
internal/kv/rocksdb/rocks_iterator.go 72.09% <ø> (ø)
internal/kv/rocksdb/rocksdb_kv.go 83.92% <ø> (-0.06%) :arrow_down:

... and 23 files with indirect coverage changes

codecov[bot] avatar Jun 08 '23 10:06 codecov[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jun 09 '23 03:06 mergify[bot]

/lgtm

jiaoew1991 avatar Jun 09 '23 07:06 jiaoew1991