milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Bug]: Milvus doesnt resort to Knowhere defaults

Open filip-halt opened this issue 1 year ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Environment

- Milvus version: Master  
- SDK version(e.g. pymilvus v2.0.0rc2): pymilvus master

Current Behavior

When creating an index using: { "index_type": "HNSW", "metric_type": "IP", "params": {} }

The process failes saying that efConstruction value isnt between 5,500.

Expected Behavior

The knowhere defailt config values should be used in this case instead of an error. This worked before.

image

The cause is from this block in indexparamcheck.

If a value is missing it shouldnt fail but rather default to HNSW config in knowhere.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

filip-halt avatar Jun 01 '23 22:06 filip-halt

/assign @longjiquan @NicoYuan1986 could you please take a look into this issue?

/unassign

yanliang567 avatar Jun 02 '23 01:06 yanliang567

Could you help confirm the milvus version and pymilvus version which resort to Knowhere defaults? It seems we always reported an error when these required parameters are not passed. /assign @filip-halt

longjiquan avatar Jun 05 '23 02:06 longjiquan

Ah, I looked through my history and saw that it was only the search params that were defaulted to. Just tested 2.2.3-present and you are right, never supported. Might be one worth supporting.

filip-halt avatar Jun 05 '23 19:06 filip-halt