milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Infer metric type from index

Open chasingegg opened this issue 1 year ago • 17 comments

Related #23849 Most codes are copied from #23615 to add indexMeta in collection

chasingegg avatar May 28 '23 10:05 chasingegg

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 28 '23 10:05 mergify[bot]

Codecov Report

Merging #24462 (02c157f) into 2.2.0 (d11bcfe) will decrease coverage by 0.01%. The diff coverage is 89.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24462      +/-   ##
==========================================
- Coverage   80.84%   80.84%   -0.01%     
==========================================
  Files         759      762       +3     
  Lines      106215   106342     +127     
==========================================
+ Hits        85874    85973      +99     
- Misses      17027    17052      +25     
- Partials     3314     3317       +3     
Impacted Files Coverage Δ
internal/core/src/common/Schema.cpp 73.33% <ø> (-4.45%) :arrow_down:
internal/querycoordv2/task/utils.go 94.00% <50.00%> (-1.84%) :arrow_down:
internal/querycoordv2/meta/coordinator_broker.go 64.41% <60.00%> (-0.45%) :arrow_down:
internal/core/src/segcore/Collection.cpp 85.71% <77.77%> (-5.96%) :arrow_down:
internal/core/src/common/IndexMeta.cpp 90.69% <90.69%> (ø)
internal/core/src/common/IndexMeta.h 100.00% <100.00%> (ø)
internal/core/src/common/protobuf_utils.h 100.00% <100.00%> (ø)
internal/core/src/query/SearchBruteForce.cpp 92.85% <100.00%> (-0.25%) :arrow_down:
internal/core/src/query/SearchOnGrowing.cpp 100.00% <100.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 100.00% <100.00%> (ø)
... and 10 more

... and 22 files with indirect coverage changes

codecov[bot] avatar May 28 '23 11:05 codecov[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '23 13:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 28 '23 13:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '23 14:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 28 '23 15:05 mergify[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 28 '23 15:05 sre-ci-robot

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '23 15:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '23 16:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 28 '23 16:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 28 '23 17:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 28 '23 17:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 29 '23 01:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 29 '23 01:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 29 '23 03:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 29 '23 05:05 mergify[bot]

/hold

czs007 avatar May 30 '23 07:05 czs007

#24583 has done the same thing, close this pr.

chasingegg avatar Jun 06 '23 05:06 chasingegg