milvus
                                
                                 milvus copied to clipboard
                                
                                    milvus copied to clipboard
                            
                            
                            
                        [Feature] Enable Nats-server as a optional MQ for Milvus
Enable Nats-server as a optional MQ for Milvus.
prototype and unit test by @yiwangdr https://github.com/milvus-io/milvus/pull/23606 more unit test, bug fix and pass e2e. Related issue: https://github.com/milvus-io/milvus/issues/23611
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
Codecov Report
Merging #24445 (e9f22af) into master (852e5ce) will increase coverage by
0.45%. The diff coverage is82.24%.
@@            Coverage Diff             @@
##           master   #24445      +/-   ##
==========================================
+ Coverage   82.18%   82.63%   +0.45%     
==========================================
  Files         777      776       -1     
  Lines      103129   102013    -1116     
==========================================
- Hits        84756    84301     -455     
+ Misses      15358    14678     -680     
- Partials     3015     3034      +19     
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/mq/msgstream/common_mq_factory.go | 57.14% <57.14%> (ø) | |
| internal/util/dependency/factory.go | 64.38% <58.13%> (+24.38%) | :arrow_up: | 
| internal/mq/msgstream/mq_factory.go | 75.00% <75.00%> (+13.46%) | :arrow_up: | 
| pkg/mq/msgstream/mqwrapper/nmq/nmq_consumer.go | 79.78% <79.78%> (ø) | |
| pkg/mq/msgstream/mqwrapper/nmq/nmq_producer.go | 80.95% <80.95%> (ø) | |
| pkg/mq/msgstream/mqwrapper/nmq/nmq_client.go | 81.25% <81.25%> (ø) | |
| pkg/mq/msgstream/mqwrapper/nmq/nmq_server.go | 85.36% <85.36%> (ø) | |
| pkg/mq/msgstream/mqwrapper/nmq/nmq_message.go | 86.95% <86.95%> (ø) | |
| pkg/util/paramtable/service_param.go | 98.45% <97.89%> (-0.10%) | :arrow_down: | 
| internal/mq/msgstream/mqwrapper/rmq/rmq_client.go | 92.30% <100.00%> (+0.81%) | :arrow_up: | 
| ... and 2 more | 
@chyezh ut workflow job failed, comment rerun ut can trigger the job again.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
move nats implementation into pkg module
commit changed:
- move nats implementation into pkg module.
- recover some orignal code of rmq implementation.
- review is replied, most of the suggestion is applied.
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
move nats implementation into pkg module
commit changed:
- move nats implementation into pkg module.
- recover some orignal code of rmq implementation.
- review is replied, most of the suggestion is applied.
Thanks, is it ready for review now?
/assign @czs007
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007, yiwangdr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment