milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix integration tests logic

Open congqixia opened this issue 1 year ago • 2 comments

  • Skip reinsert in show index stats test case
  • Fix show replica logic error
  • Add singleton logic in gc_tuner
  • Create folder for GenerateNumpyFile
  • Remove continue-on-error for integration test job

Related to #24017 /kind improvement

congqixia avatar May 12 '23 03:05 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 12 '23 06:05 sre-ci-robot

Codecov Report

Merging #24063 (e569a79) into master (f6dec28) will decrease coverage by 0.08%. The diff coverage is 74.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24063      +/-   ##
==========================================
- Coverage   82.14%   82.07%   -0.08%     
==========================================
  Files         754      754              
  Lines       98672    98871     +199     
==========================================
+ Hits        81055    81146      +91     
- Misses      14635    14702      +67     
- Partials     2982     3023      +41     
Impacted Files Coverage Δ
pkg/util/paramtable/base_table.go 80.53% <0.00%> (ø)
pkg/util/gc/gc_tuner.go 68.67% <68.75%> (-11.82%) :arrow_down:
pkg/util/paramtable/quota_param.go 75.51% <70.61%> (-2.71%) :arrow_down:
internal/proxy/multi_rate_limiter.go 89.68% <100.00%> (+1.01%) :arrow_up:
internal/rootcoord/quota_center.go 87.78% <100.00%> (-2.30%) :arrow_down:

... and 17 files with indirect coverage changes

codecov[bot] avatar May 12 '23 07:05 codecov[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 15 '23 03:05 mergify[bot]

/lgtm

jiaoew1991 avatar May 15 '23 06:05 jiaoew1991